Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a feature request issue template. #588

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Jul 17, 2024

Add a new template for feature request issues.

This is currently a draft as I want to make sure we encapsulate everything first.

description: A feature request for WildFly
title: "[RFE]: "
labels: ["feature"]
projects: ["wildfly/7"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to consider using a workflow to add the project if not everyone create an issue will have write access. See https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms.

@@ -0,0 +1,32 @@
name: Feature Request
description: A feature request for WildFly
title: "[RFE]: "
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we prefix with "[RFE]: ", nothing or something elese?

@@ -0,0 +1,32 @@
name: Feature Request
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use the term "Feature Request" or is there something better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Enhancement Proposal"? "Enhancement"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enhancement has a meaning that's not relevant here. In JIRA we use it for improvements that bring direct user benefit but are not user controllable. I'd prefer not to confuse that.

'Feature' seems reasonable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW 'Feature Request' seems ok to me too if we want to follow KISS principles and align with JIRA. But I get how the 'Request' part is odd here as these issues are never requests that someone do something, they are statements of intent to do something.

@jamezp jamezp marked this pull request as ready for review July 17, 2024 19:14
@jamezp jamezp force-pushed the feature-request-issue-template branch 3 times, most recently from d9ce5db to 8d9a9aa Compare September 11, 2024 17:20
@jamezp
Copy link
Member Author

jamezp commented Sep 11, 2024

Example

@jamezp
Copy link
Member Author

jamezp commented Sep 11, 2024

Note that outside perspective is required for the template. We could make the other ones required as well, but we don't have to. The question becomes what we want to see in the issue vs what we want on the actual proposal document.

@@ -0,0 +1,32 @@
name: Feature Request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Enhancement Proposal"? "Enhancement"?

description: A link to the main feature request JIRA.
placeholder: ex. https://issues.redhat.com/browse/WFLY-XXX
validations:
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really required to propose a new feature enhancement?

It's needed for the analysis document but for proposing something that might be too early. It might not be necessarily known beforehand which projects would be impacted by the proposal (WFLY, WFCORE, WFMP, etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this doesn't really need to be required I suppose. The idea here is we use this for RFE's that are effectively already in progress. This will not be meant to track features we want to have, just features we're actively working on for a release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data is necessary in the proposal, so repeating it here is added overhead.

options:
- community
- preview
- experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add default too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this data should come from the proposal adoc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely remove this.

id: sme
attributes:
label: Subject Matter Expert
description: The name of the person who is the subject matter expert.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe specify the person with their GitHub handle (e.g. @jamezp)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that. There isn't really a field type for that.

id: outside-perspective
attributes:
label: Outside Perspective
description: The name of the person who is the outside perspective for this feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe let the user proposing the enhancement know that they can put themselves as the "Outsider"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can validate this based on the stability level that would be ideal. It's N/A for 'experimental', otherwise required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the overall 'validation' pattern. We always need the SME and the developer, while requiring the outside perspective depends on the stability level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I think this feature team stuff should be in the proposal as well, as front matter. We talk about the 'required' feature team, but those are really minimums. There's one person who's the primary assignee (the default person to contact), then there are 1..n SMEs, and then [0|1]..n outsiders. This latter two are modeled as lists, which is doable via adoc front matter.

Recording that here is ok, if we remove it from the proposal and the feature team itself will be able to maintain it in the issue.

Note: I'm really thinking out loud here; I think we can iterate on this and not block too much.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the overall 'validation' pattern. We always need the SME and the developer, while requiring the outside perspective depends on the stability level.

But I realize this validation is about the initial filing, and for that we need to know the assignee and the rest is optional.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can do whatever really. Making all or none of them required seems reasonable. Maybe for now, just none of them required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the Developer is required (which AIUI is the person we call the 'assignee'). The issue filer may not be that person, particularly early on when those of us working on tooling / process may be doing the paperwork.

title: ""
labels: ["feature"]
projects: ["wildfly/7"]
body:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add a markdown type to give more contextual information for the user submitting the proposal (without polluting the created issue with this blurb of text).

This would give the user more info about what we are expecting for them when they fill the form.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we could do that.

@@ -0,0 +1,53 @@
name: Feature Request
description: A feature request for WildFly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new feature for WildFly

Signed-off-by: James R. Perkins <jperkins@redhat.com>
@jamezp jamezp force-pushed the feature-request-issue-template branch from 8d9a9aa to 100d978 Compare September 25, 2024 16:21
@jamezp
Copy link
Member Author

jamezp commented Sep 25, 2024

@jmesnil @bstansberry @darranl I've updated the template to be more simplistic and not duplicate attributes. You can see an example of what it would look like here https://github.com/jamezp/wildfly-proposals/issues/new?assignees=&labels=feature&projects=wildfly%2F7&template=feature-development.yaml

@darranl
Copy link
Contributor

darranl commented Sep 25, 2024

FYI for anyone reviewing, we have discussed if we can get a simplified issue template introduced and merged and we will continue to evolve as we experience using it so reviews here are not a last change to make updates etc...

Maybe we can use this data in some way.
@bstansberry bstansberry merged commit b4f7756 into wildfly:main Sep 25, 2024
1 check passed
@bstansberry
Copy link
Contributor

Thanks @jamezp @jmesnil @darranl

@jamezp jamezp deleted the feature-request-issue-template branch October 8, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants