Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue_608] [Preview] Jakarta Data support in standard WildFly #666

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

bstansberry
Copy link
Contributor

For #608

@github-actions github-actions bot added the stability-level/preview "Preview" stability level label Nov 22, 2024
@github-actions github-actions bot added stability-level/preview "Preview" stability level and removed stability-level/preview "Preview" stability level labels Nov 27, 2024
Copy link

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I just have a comment about the user stories. No sure it requires any change, but at least we'll be on the same page.

Comment on lines 38 to 47
I'm an application developer and I'd like to be less concerned with the mechanics of manipulating persistent data. I'd like to define my entities and then write an interface that describes the CRUD and data access operations I need. I code against that interface and let WildFly take care of generating the interface implementation that deals with the DB.

I'm an application developer and am familiar with the Repository pattern from use of Spring Data. I'd like to use that pattern in WildFly in non-Spring applications.

I'm an application developer who's used Deltaspike Data, which uses a repository pattern. But it doesn't support EE > 8, so I'm looking for a similar technology to run on the latest WildFly releases.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to mention that users need to be fine with having less flexibility, in particular:

  • Simpler query language.
  • No lazy loading -- or only explicit lazy loading by using Hibernate ORM native APIs.
  • More limited support for dynamic queries; I think there is some support for dynamic predicates, but it far from the Criteria API.
  • And so on.

Which is fine, but it does mean that it's not just about what developers "like", it's also about the complexity of their use case: Jakarta Data is great in many cases, but may be too limited in others.

Note that it's perfectly possible to use standard JPA, native Hibernate ORM APIs, and Jakarta Data in the same application. Depending on how the stateless session is injected into Jakarta Data, it's probably even possible to use Hibernate ORM APIs (StatelessSession) and Jakarta Data in the same transaction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yrodiere. I incorporated a lot of your info above in the first user story.

@github-actions github-actions bot added stability-level/preview "Preview" stability level and removed stability-level/preview "Preview" stability level labels Dec 3, 2024
** This layer will be shared with the `wildfly-preview` feature pack. (This is the norm for `wildfly-ee` layers).
* The Jakarta Data API artifact *must not* be part of the standard WildFly user boms. We limit the user boms to `community` stability artifacts.
* The Jakarta Data API artifact must contintue to be part of the WildFly Preview user boms.
* The wildfly-tck-runners Jakarta Data runner will be modified to test the `wildfly` feature pack by default, while allowing testing of `wildfly-preview`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'll do this after the 35 Beta release as the runner shouldn't depend on a SNAPSHOT.

@bstansberry bstansberry merged commit 0baf062 into wildfly:main Dec 5, 2024
1 check passed
@bstansberry bstansberry deleted the Issue_608 branch December 5, 2024 01:42
@bstansberry
Copy link
Contributor Author

Thanks @yrodiere and @jasondlee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability-level/preview "Preview" stability level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants