Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dzint/non manifold simplification #743

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

daniel-zint
Copy link
Contributor

Adding two components:

  1. non_manifold_input
  2. non_manifold_simplification

@daniel-zint daniel-zint requested review from mtao and JcDai March 23, 2024 00:00
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 91.98718% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 83.52%. Comparing base (8b3a6b4) to head (2a0238f).

Files Patch % Lines
...old_simplification/non_manifold_simplification.cpp 86.75% 20 Missing ⚠️
...mponents/non_manifold_input/non_manifold_input.cpp 92.18% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   83.36%   83.52%   +0.16%     
==========================================
  Files         345      349       +4     
  Lines       13829    14059     +230     
==========================================
+ Hits        11528    11743     +215     
- Misses       2301     2316      +15     
Flag Coverage Δ
wildmeshing 83.52% <91.98%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant