-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamlined file sharing. #161
Conversation
@zsteinmetz this one has a few bug fixes and some new functionality, I got the check and tests all working and ready for your final review when you have time. |
Hey @wincowgerDEV. Hope you're doing well! Thanks for keeping the ball rolling. I'll have a look as soon as I can and prepare a new CRAN submission afterwards .. |
Hope you are doing well too man! No worries on the timing, these are mostly nice to have. Lots of new people have been using the package which is super exciting! |
@zsteinmetz I know we talked about this a while back but I think it might be time to bring the sgolay filter function in front the signal package. This will allow us to customize it and I think they have a subfunction in it that interpolates values near the tails. We could really use that to improve the new conform_spec and smooth_spec methods I added. Let me know what you think and if you have any ideas after testing things out. |
Added all this and a bag of chips: #165 I think the last thing to do on this @zsteinmetz is probably add a few specific tests and example routines for the new spatial smoother functions. Hmm, somehow it is failing on this server but not on my personal comp, will check that too. |
Got the error fixed but still one warning about global variables to fix. |
…y break some functions downstream if used but needed for allowing the library to be used accurately.
@zsteinmetz, I think I have things stable again, everything is always a work in progress but would love to get these new features out soon so that we can roll them out on the web site. I know you are super busy but would greatly appreciate if you have a chance to review these updates before we push to cran. |
Going to merge to main so that others can start using while we prep for cran. |
This primarily add support for the new csv format described in #160
Adds a new function for calculating the number of spectral points needed to fill a window with wavenumber specification.
8f8dd47
Also adds a minor bug fix for duplicate column names when xy are used in the metadata. f4d5523
And adds a new experimental function for interpreting the similarity between Open Specy objects:
2c3cf9e