Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodes-file-dir configuration #107

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

ohkinozomu
Copy link
Contributor

close #106

@wind-c
Copy link
Owner

wind-c commented Aug 3, 2024

NodesFile is used to assist memberlist to discover nodes, and PeersFile is used to assist Raft to discover peers.
RaftDir stores all the data generated during raft running, so there is no need to put NodesFile in the RaftDir directory.

@ohkinozomu ohkinozomu force-pushed the include-nodesfile-in-raftdir branch from 50de104 to 6f5701e Compare August 3, 2024 22:35
@ohkinozomu ohkinozomu changed the title Include NodesFile in RaftDir Add nodes-file-dir configuration Aug 3, 2024
@ohkinozomu
Copy link
Contributor Author

Understood.
I have updated the pull request to make NodesFileDir configurable.
This change should be helpful for other comqtt users as well.
What do you think?

@ohkinozomu ohkinozomu force-pushed the include-nodesfile-in-raftdir branch from 6f5701e to 01b08e5 Compare August 3, 2024 22:43
@wind-c
Copy link
Owner

wind-c commented Aug 4, 2024

Ok

@wind-c wind-c merged commit 136df72 into wind-c:main Aug 4, 2024
1 check passed
@ohkinozomu ohkinozomu deleted the include-nodesfile-in-raftdir branch August 13, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Include NodesFile in RaftDir
2 participants