Prevent rerunning scripts already ran in router

[matthewp]

Changes

• In a long session you might navigate between several pages, some contain the script and some not, but nevertheless the script should run a total of 1 time.
• This also helps with smaller bundled scripts in production, where some are inlined.
• Keeps track of scripts that have run, either by the src or by the inner text (for inline scripts) and uses that as a key, rather than the data attribute we previously adde.

Testing

• Updated the existing tests to navigate between more pages.

Docs

N/A, bug fix.

[changeset-bot]

🦋 Changeset detected

Latest commit: fe845fe

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #12985 will not alter performance

_{Comparing rem-router-page (fe845fe) with main (1a026af)}

Summary

✅ 6 untouched benchmarks

[martrapp]

Looks like what we discussed on discord ;-)
Left two comments.

[martrapp]

Navigation across pages 3 and 5 will do a full page load as those don't use the client router.

[matthewp]

Ah oops, ok I'll create a new page that does use it then.

[martrapp]

maybe move checking the type attribute two lines up as we do not need to remember e.g. speculation rules, import maps, or partytown scripts

[martrapp]

With that change in place, we can also remove

astro/packages/astro/src/transitions/swap-functions.ts

Lines 9 to 30 in 0968069

	/*
	* Mark new scripts that should not execute
	*/
	export function deselectScripts(doc: Document) {
	for (const s1 of document.scripts) {
	for (const s2 of doc.scripts) {
	if (
	// Check if the script should be rerun regardless of it being the same
	!s2.hasAttribute('data-astro-rerun') &&
	// Inline
	((!s1.src && s1.textContent === s2.textContent) ||
	// External
	(s1.src && s1.type === s2.type && s1.src === s2.src))
	) {
	// the old script is in the new document and doesn't have the rerun attribute
	// we mark it as executed to prevent re-execution
	s2.dataset.astroExec = '';
	break;
	}
	}
	}
	}

and

astro/packages/astro/src/transitions/swap-functions.ts

Line 153 in 0968069

deselectScripts(doc);