Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ideviceinfo): add spec #2510

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jawshoeadan
Copy link

No description provided.

@withfig-bot
Copy link
Collaborator

withfig-bot commented Nov 20, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@withfig-bot
Copy link
Collaborator

Overview

src/ideviceinfo.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @jawshoeadan,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@jawshoeadan
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request Nov 20, 2024
@jawshoeadan
Copy link
Author

I would also like some feedback on my implementation of the connectediOSDevices generator, as I show a display name different from what's actually filled in to make it easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants