Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix by RobertGnz for too long messages and new function deleteMessage #348

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

francwalter
Copy link

@francwalter francwalter commented Mar 11, 2024

Fix by RobertGnz:
"If deserializeJson happen to endup with an error for instance update too big for the buffer, then last_message_received will not be updated. Subsequent calls to getUpdates uses last_message_received + 1 for the offset value. But as last_message_received was not updated we will allways read the same message. Here we try to find the update_id and store it to update last_message_received if necessary."
See: #275 and #266

Created deleteMessage as a new function. This is the deleteMessage from another PR, I considered it better than mine, so I replaced it.

Added the deleteMessage in README.md, but missing is an example yet.

I hope this PR is a better one than my first, where I commented in german and changed the README.md to tell it is a fork 😏
frank

EDIT: Oh, I noticed that I forgot to put back the "Help support what I do!" part in the README.md with the sponsor beg.
If this PR is near to get pulled, I could (force) add it again, just leave a comment here @witnessmenow Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant