Skip to content

Commit

Permalink
Make the minimum supported .NET Framework v4.6.2
Browse files Browse the repository at this point in the history
  • Loading branch information
robmen committed Dec 19, 2023
1 parent 7b63b09 commit f02ef4a
Show file tree
Hide file tree
Showing 39 changed files with 57 additions and 58 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ This repository contains the WiX Toolset codebase.

## Prerequisites

- Microsoft .NET Framework 3.5 SP1
- A command line Git client that is in the system path
- Visual Studio 2022 (17.8.2 or higher) with the following installed:

Expand All @@ -27,6 +26,7 @@ This repository contains the WiX Toolset codebase.
| .NET 6.0 Runtime (Long Term Support) |
| .NET Framework 4.7.2 SDK |
| .NET Framework 4.7.2 targeting pack |
| .NET Framework 4.6.2 targeting pack |
| MSVC v141 - VS 2017 C++ ARM64 build tools (v14.16) |
| MSVC v141 - VS 2017 C++ x64/x86 build tools (v14.16) |
| MSVC v143 - VS 2022 C++ ARM64/ARM64EC build tools (Latest) |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>netstandard2.0;net20</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<AssemblyName>WixToolset.Mba.Core</AssemblyName>
<RootNamespace>WixToolset.Mba.Core</RootNamespace>
<DebugType>embedded</DebugType>
Expand Down
6 changes: 3 additions & 3 deletions src/api/burn/WixToolset.Mba.Core/WixToolset.Mba.Core.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@
<projectUrl>$projectUrl$</projectUrl>
<repository type="$repositorytype$" url="$repositoryurl$" commit="$repositorycommit$" />
<dependencies>
<group targetFramework=".NETFramework2.0" />
<group targetFramework=".NETFramework4.6.2" />
<group targetFramework=".NETStandard2.0" />
</dependencies>
</metadata>

<files>
<file src="$projectFolder$\..\..\..\internal\images\wix.png" />
<file src="net20\$id$.dll" target="lib\net20" />
<file src="net20\$id$.xml" target="lib\net20" />
<file src="net462\$id$.dll" target="lib\net462" />
<file src="net462\$id$.xml" target="lib\net462" />
<file src="netstandard2.0\$id$.dll" target="lib\netstandard2.0" />
<file src="netstandard2.0\$id$.xml" target="lib\netstandard2.0" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<RootNamespace>WixToolset.Dtf.Compression.Cab</RootNamespace>
<AssemblyName>WixToolset.Dtf.Compression.Cab</AssemblyName>
<TargetFrameworks>netstandard2.0;net20</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<Description>Managed libraries for cabinet archive packing and unpacking</Description>
<CreateDocumentationFile>true</CreateDocumentationFile>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<RootNamespace>WixToolset.Dtf.Compression.Zip</RootNamespace>
<AssemblyName>WixToolset.Dtf.Compression.Zip</AssemblyName>
<TargetFrameworks>netstandard2.0;net20</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<Description>Managed libraries for zip archive packing and unpacking</Description>
<CreateDocumentationFile>true</CreateDocumentationFile>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<RootNamespace>WixToolset.Dtf.Compression</RootNamespace>
<AssemblyName>WixToolset.Dtf.Compression</AssemblyName>
<TargetFrameworks>netstandard2.0;net20</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<Description>Abstract base libraries for archive packing and unpacking</Description>
<CreateDocumentationFile>true</CreateDocumentationFile>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<RootNamespace>WixToolset.Dtf.Resources</RootNamespace>
<AssemblyName>WixToolset.Dtf.Resources</AssemblyName>
<TargetFrameworks>netstandard2.0;net20</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<Description>Classes for reading and writing resource data in executable files</Description>
<CreateDocumentationFile>true</CreateDocumentationFile>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<RootNamespace>WixToolset.Dtf.WindowsInstaller.Linq</RootNamespace>
<AssemblyName>WixToolset.Dtf.WindowsInstaller.Linq</AssemblyName>
<TargetFrameworks>netstandard2.0;net35</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<Description>LINQ extensions for Windows Installer classes</Description>
<CreateDocumentationFile>true</CreateDocumentationFile>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<RootNamespace>WixToolset.Dtf.WindowsInstaller</RootNamespace>
<AssemblyName>WixToolset.Dtf.WindowsInstaller.Package</AssemblyName>
<TargetFrameworks>netstandard2.0;net20</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<Description>Extended managed libraries for Windows Installer</Description>
<CreateDocumentationFile>true</CreateDocumentationFile>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ private static bool FindEntryPoint(
}
else
{
#if NET20
#if NETFRAMEWORK
IDictionary config;
try
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<RootNamespace>WixToolset.Dtf.WindowsInstaller</RootNamespace>
<AssemblyName>WixToolset.Dtf.WindowsInstaller</AssemblyName>
<TargetFrameworks>netstandard2.0;net20</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<Description>Managed libraries for Windows Installer</Description>
<CreateDocumentationFile>true</CreateDocumentationFile>
</PropertyGroup>
Expand All @@ -19,7 +19,7 @@
<None Include="WindowsInstaller.cd" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)'=='net20' ">
<ItemGroup Condition=" '$(TargetFramework)'=='net462' ">
<Reference Include="System.Configuration" />
</ItemGroup>
</Project>
1 change: 0 additions & 1 deletion src/ext/Bal/WixToolset.Mba.Host/WixToolset.Mba.Host.config
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
</configSections>
<startup useLegacyV2RuntimeActivationPolicy="true">
<supportedRuntime version="v4.0" />
<supportedRuntime version="v2.0.50727" />
</startup>
<wix.bootstrapper>
<!-- Example only. Use only if the startup/supportedRuntime above cannot discern supported frameworks. -->
Expand Down
2 changes: 1 addition & 1 deletion src/ext/Bal/WixToolset.Mba.Host/WixToolset.Mba.Host.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<AssemblyName>WixToolset.Mba.Host</AssemblyName>
<RootNamespace>WixToolset.Mba.Host</RootNamespace>
<TargetFrameworks>net20</TargetFrameworks>
<TargetFrameworks>net462</TargetFrameworks>
<Description>Managed Bootstrapper Application entry point</Description>
<DebugType>embedded</DebugType>
<NuspecFile>$(MSBuildThisFileName).nuspec</NuspecFile>
Expand Down
6 changes: 3 additions & 3 deletions src/ext/Bal/WixToolset.Mba.Host/WixToolset.Mba.Host.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
<projectUrl>$projectUrl$</projectUrl>
<repository type="$repositorytype$" url="$repositoryurl$" commit="$repositorycommit$" />
<dependencies>
<group targetFramework=".NETFramework2.0" />
<group targetFramework=".NETFramework4.6.2" />
</dependencies>
</metadata>

<files>
<file src="$projectFolder$\..\..\..\internal\images\wix.png" />
<file src="net20\$id$.config" target="samples" />
<file src="net20\$id$.dll" target="lib\net20" />
<file src="net462\$id$.config" target="samples" />
<file src="net462\$id$.dll" target="lib\net462" />
</files>
</package>
8 changes: 4 additions & 4 deletions src/ext/Bal/test/examples/FullFramework2Bundle/Bundle.wxs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs" xmlns:bal="http://wixtoolset.org/schemas/v4/wxs/bal">
<Bundle Name="FullFramework2MBA" Version="1.0.0.0" Manufacturer="Example Corporation" UpgradeCode="5CE5B5C7-4B6B-4B95-B297-731F1F956533">
<BootstrapperApplication>
<Payload SourceFile="Example.FullFramework2MBA\net20\win-x64\Example.FullFramework2MBA.dll" />
<Payload SourceFile="Example.FullFramework2MBA\net20\win-x64\mbanative.dll" />
<Payload SourceFile="Example.FullFramework2MBA\net20\win-x64\WixToolset.Mba.Core.dll" />
<Payload SourceFile="Example.FullFramework2MBA\net20\win-x64\WixToolset.Mba.Host.config" />
<Payload SourceFile="Example.FullFramework2MBA\net462\win-x64\Example.FullFramework2MBA.dll" />
<Payload SourceFile="Example.FullFramework2MBA\net462\win-x64\mbanative.dll" />
<Payload SourceFile="Example.FullFramework2MBA\net462\win-x64\WixToolset.Mba.Core.dll" />
<Payload SourceFile="Example.FullFramework2MBA\net462\win-x64\WixToolset.Mba.Host.config" />
<bal:WixManagedBootstrapperApplicationHost />
</BootstrapperApplication>
<Chain>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net20</TargetFramework>
<TargetFramework>net462</TargetFramework>
<AssemblyName>Example.FullFramework2MBA</AssemblyName>
<RootNamespace>Example.FullFramework2MBA</RootNamespace>
<DebugType>embedded</DebugType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
</sectionGroup>
</configSections>
<startup>
<supportedRuntime version="v2.0.50727" />
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.2" />
</startup>
<wix.bootstrapper>

<host assemblyName="Example.FullFramework2MBA">
<supportedFramework version="v3.5" />
<supportedFramework version="v4\Client" />
</host>
</wix.bootstrapper>
</configuration>
8 changes: 4 additions & 4 deletions src/ext/Bal/test/examples/FullFramework4Bundle/Bundle.wxs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs" xmlns:bal="http://wixtoolset.org/schemas/v4/wxs/bal">
<Bundle Name="FullFramework4MBA" Version="1.0.0.0" Manufacturer="Example Corporation" UpgradeCode="E08068E0-4FBA-439D-A1C8-4CD1FE27093F">
<BootstrapperApplication>
<Payload SourceFile="Example.FullFramework4MBA\net48\win-x64\Example.FullFramework4MBA.dll" />
<Payload SourceFile="Example.FullFramework4MBA\net48\win-x64\mbanative.dll" />
<Payload SourceFile="Example.FullFramework4MBA\net48\win-x64\WixToolset.Mba.Core.dll" />
<Payload SourceFile="Example.FullFramework4MBA\net48\win-x64\WixToolset.Mba.Host.config" />
<Payload SourceFile="Example.FullFramework4MBA\net472\win-x64\Example.FullFramework4MBA.dll" />
<Payload SourceFile="Example.FullFramework4MBA\net472\win-x64\mbanative.dll" />
<Payload SourceFile="Example.FullFramework4MBA\net472\win-x64\WixToolset.Mba.Core.dll" />
<Payload SourceFile="Example.FullFramework4MBA\net472\win-x64\WixToolset.Mba.Host.config" />
<bal:WixManagedBootstrapperApplicationHost />
</BootstrapperApplication>
<Chain>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net48</TargetFramework>
<TargetFramework>net472</TargetFramework>
<Description>Full Framework v4 MBA</Description>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</sectionGroup>
</configSections>
<startup>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8" />
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.2" />
</startup>
<wix.bootstrapper>
<host assemblyName="Example.FullFramework4MBA" />
Expand Down
2 changes: 1 addition & 1 deletion src/ext/Bal/wixlib/bal.wixproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<ItemGroup>
<BindPath Include="..\wixstdba\Resources\" />
<BindPath Include="$(OutputPath)net20" />
<BindPath Include="$(OutputPath)net462" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/test/burn/TestBA/TestBA.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net35;net6.0-windows</TargetFrameworks>
<TargetFrameworks>net462;net6.0-windows</TargetFrameworks>
<AssemblyName>TestBA</AssemblyName>
<RootNamespace>WixToolset.Test.BA</RootNamespace>
<DebugType>embedded</DebugType>
Expand All @@ -13,7 +13,7 @@
<RollForward>Major</RollForward>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)'=='net35' ">
<ItemGroup Condition=" '$(TargetFramework)'=='net462' ">
<Content Include="TestBA.BootstrapperCore.config" CopyToOutputDirectory="PreserveNewest" />
<Reference Include="System.Windows.Forms" />
</ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/test/burn/TestBA/TestBA_x64.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net35;net6.0-windows</TargetFrameworks>
<TargetFrameworks>net462;net6.0-windows</TargetFrameworks>
<AssemblyName>TestBA</AssemblyName>
<RootNamespace>WixToolset.Test.BA</RootNamespace>
<DebugType>embedded</DebugType>
Expand All @@ -13,7 +13,7 @@
<RollForward>Major</RollForward>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)'=='net35' ">
<ItemGroup Condition=" '$(TargetFramework)'=='net462' ">
<Content Include="TestBA.BootstrapperCore.config" CopyToOutputDirectory="PreserveNewest" />
<Reference Include="System.Windows.Forms" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<Compile Include="..\..\Templates\Bundle.wxs" Link="Bundle.wxs" />
</ItemGroup>
<ItemGroup>
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net35\win-x86" BindName="net2x86" />
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net462\win-x86" BindName="net2x86" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PackageB\PackageB.wixproj" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<Compile Include="..\..\Templates\Bundle.wxs" Link="Bundle.wxs" />
</ItemGroup>
<ItemGroup>
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net35\win-x86" BindName="net2x86" />
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net462\win-x86" BindName="net2x86" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\PackageB\PackageB.wixproj" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Cultures>en-us</Cultures>
</PropertyGroup>
<ItemGroup>
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net35\win-x86" BindName="net2x86" />
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net462\win-x86" BindName="net2x86" />
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net472\win-x86" BindName="net4x86" />
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net6.0-windows\win-x86" BindName="dncx86" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<InstallerPlatform>x64</InstallerPlatform>
</PropertyGroup>
<ItemGroup>
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net35\win-x64" BindName="net2x64" />
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net462\win-x64" BindName="net2x64" />
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net472\win-x64" BindName="net4x64" />
<BindInputPaths Include="$(BaseOutputPath)$(Configuration)\net6.0-windows\win-x64" BindName="dncx64" />
</ItemGroup>
Expand All @@ -17,7 +17,7 @@
the required target framework. Since we want all target frameworks built,
the above line is shorter.
<ProjectReference Include="..\..\..\TestBA\TestBA_x64.csproj">
<SetTargetFramework>TargetFramework=net35</SetTargetFramework>
<SetTargetFramework>TargetFramework=net462</SetTargetFramework>
</ProjectReference>
<ProjectReference Include="..\..\..\TestBA\TestBA_x64.csproj">
<SetTargetFramework>TargetFramework=net5.0-windows</SetTargetFramework>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net35</TargetFramework>
<TargetFramework>net462</TargetFramework>
<Description>Sample managed embedded external UI</Description>
<UseWPF>true</UseWPF>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net20</TargetFramework>
<TargetFramework>net462</TargetFramework>
<Description>Sample managed custom actions</Description>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/test/burn/TestExe/NetfxTask.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information.

#if NET35
#if NETFRAMEWORK
using System;
using System.Collections.Generic;
using System.Diagnostics;
Expand Down
2 changes: 1 addition & 1 deletion src/test/burn/TestExe/Task.cs
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ public static List<Task> ParseTasks(string[] args)
t = new DeleteManifestsTask(args[i + 1]);
tasks.Add(t);
break;
#if NET35
#if NETFRAMEWORK
case "/pinfo":
t = new ProcessInfoTask(args[i + 1]);
tasks.Add(t);
Expand Down
4 changes: 2 additions & 2 deletions src/test/burn/TestExe/TestExe.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net35;net6.0</TargetFrameworks>
<TargetFrameworks>net462;net6.0</TargetFrameworks>
<AssemblyName>TestExe</AssemblyName>
<RootNamespace>TestExe</RootNamespace>
<OutputType>Exe</OutputType>
Expand All @@ -14,7 +14,7 @@
<RollForward>Major</RollForward>
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)'=='net35'">
<ItemGroup Condition="'$(TargetFramework)'=='net462'">
<Reference Include="System.Management" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/test/burn/TestExe/TestExe_x64.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net35</TargetFrameworks>
<TargetFrameworks>net462</TargetFrameworks>
<AssemblyName>TestExe</AssemblyName>
<RootNamespace>TestExe</RootNamespace>
<OutputType>Exe</OutputType>
Expand Down
2 changes: 1 addition & 1 deletion src/test/burn/test_burn.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
msbuild -Restore -p:Configuration=%_C% -tl -nologo -m -warnaserror -bl:%_L%\test_burn_build.binlog || exit /b
msbuild -Restore TestData\TestData.proj -p:Configuration=%_C% -tl -nologo -m -warnaserror -bl:%_L%\test_burn_data_build.binlog || exit /b

"%_B%\net35\win-x86\testexe.exe" /dm "%_B%\net6.0-windows\testhost.exe"
"%_B%\net462\win-x86\testexe.exe" /dm "%_B%\net6.0-windows\testhost.exe"
mt.exe -manifest "WixToolsetTest.BurnE2E\testhost.longpathaware.manifest" -updateresource:"%_B%\net6.0-windows\testhost.exe"

@if not "%RuntimeTestsEnabled%"=="true" goto :LExit
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net48</TargetFrameworks>
<TargetFrameworks>net6.0;net472</TargetFrameworks>
<DebugType>embedded</DebugType>
</PropertyGroup>

Expand Down
Loading

0 comments on commit f02ef4a

Please sign in to comment.