A number of minor fixes for WiX v6 #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
barnson
commented
Jun 30, 2024
•
barnson
commented
- Remove unused const.
- For fields, "" != null - fixes FileSearch does not work in a Merge Module issues#8558
- Exclude detect-only Upgrades from default-feature - fixes Default major upgrade is not working if ProductSearch is used issues#8125
- Fix default feature to respect sections.
robmen
requested changes
Jul 15, 2024
src/wix/WixToolset.Core/Linker.cs
Outdated
| } | ||
|
|
||
| resolve = new ResolveReferencesCommand(this.Messaging, find.EntrySection, find.SymbolsByName); | ||
| resolve.Execute(); |
There was a problem hiding this comment.
The other commits look fine but I want to look at a different solution than calling resolve references twice. This could introduce lots of complexity.
There was a problem hiding this comment.
Please enjoy. Would you like an issue to track?
barnson
force-pushed
the
bob/Fixes.240629
branch
from
845b9ef
to
c597f0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.