adding color #4
adding color #4
Conversation
added images showing output with colors
|
Thanks, this is interesting, but I want to make colours optional so that |
| @@ -3,6 +3,10 @@ | |||
| # | |||
| # See functions "_usage" and "_help" for more details. | |||
|
|
|||
| ## COLOR | |||
| GREEN="\033[0;32m" | |||
| NORMAL="\033[0;00m" | |||
| ## COLOR | ||
| GREEN="\033[0;32m" | ||
| NORMAL="\033[0;00m" | ||
| RED="\033[0;31m" |
There was a problem hiding this comment.
On source, these will be in the environment and could easily be overwritten. I would obfuscate them like the functions: _What_GREEN etc
| @@ -38,7 +43,8 @@ function _What_alias { ( | |||
| if [[ $print_definition == true ]]; then | |||
| # Print the *current* definition. | |||
| _What_indent 2 | |||
| printf "definition: " | |||
| # shellcheck disable=SC2059 | |||
There was a problem hiding this comment.
No reason to do this when you can use %b instead: printf "%bdefinition%b: " "$GREEN" "$NORMAL"
| @@ -228,19 +236,20 @@ function _What_function { ( | |||
| read -r _ attrs _ <<< "$(declare -pF -- "$function")" | |||
|
|
|||
| # Find the source by turning on extended debugging. | |||
| # Looping not required because only one definition exists at a time. | |||
| # Looping not required because only one exists at a time. | |||
There was a problem hiding this comment.
Why remove? Is this just a typo?
so can i add a option like |
Yeah, that'd work. Although, (Sorry for the delay. I missed your reply somehow.) |
okay |
dded color RED for: keyword, builtin, alias/file, function, multiple
files/absolute symlinks, relative symlink
and color GREEN for the rest.
added output example with color for the README file.