Remove compile-time dependencies from key tools #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielinux
force-pushed
the
build-keytools-windows
branch
from
b5680a9 to
1f1cf14
Compare
* Update key tools VS project to 2022. * Fix a few warnings in sign.c * Fix issues with windows already having min/max. * Fix (workaround) issue with key tools needing WOLFBOOT_SECTOR_SIZE.
dgarske
force-pushed
the
build-keytools-windows
branch
from
ce620ff to
bf4c801
Compare
dgarske
previously approved these changes
Nov 25, 2024
|
@danielinux please review workaround for delta.c in sign tools needing to know the sector size (WOLFBOOT_SECTOR_SIZE). Perhaps consider making this an argument or taking in the .config at runtime / arg. |
- Added getenv() to override the value at runtime - Removed doc on old python tools
danielinux
force-pushed
the
build-keytools-windows
branch
from
2e12215 to
75efbd9
Compare
danielinux
changed the title
dgarske
previously approved these changes
Dec 5, 2024
bigbrett
previously approved these changes
Dec 5, 2024
philljj
previously requested changes
Dec 5, 2024
bigbrett
previously approved these changes
Dec 5, 2024
…L-DSA levels at run-time using `ML_DSA_LEVEL` environment variable. wolfBoot needs to be built with the correct level specified in the .config.
dgarske
force-pushed
the
build-keytools-windows
branch
from
cc17b31 to
6bed80f
Compare
dgarske
approved these changes
Dec 5, 2024
bigbrett
approved these changes
Dec 5, 2024
bigbrett
added a commit
to bigbrett/wolfBoot
that referenced
this pull request
Dec 6, 2024
danielinux
pushed a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all compile-time configuration from key tools, to allow for binary distribution of generic, pre-compiled artifacts.
Add action to build keytools on windows.
Requires wolfSSL/wolfssl#8257