refactor: improve the logic for setting options in readMany and search #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
During the validation stage,
withDeleted
was assigned redundantly with default values, and this was being serialized in the query(nextCursor).setSort
andsetOrder
both set the sort and order, making their roles unclear.What is the new behavior?
Default value for
withDeleted
is assigned only in the intercept method, and only user input is serialized in the query.setSort
andsetOrder
only set values. Calculated sort and order values are passed by the readMany/search interceptor.Does this PR introduce a breaking change?
Other information
separated PR from #579