Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#353 유틸함수 테스트 보강 #356

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat/#353 유틸함수 테스트 보강 #356

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcac72a
test: formatOrdinals 테스트 추가
ukkodeveloper Sep 1, 2023
b7be15b
test: useDebounceEffect 테스트
ukkodeveloper Sep 1, 2023
76781ec
test: useFetch 테스트
ukkodeveloper Sep 1, 2023
c732e01
test: useMutation 테스트 추가
ukkodeveloper Sep 1, 2023
3a82107
test: useDebounceEFfect react hook 제거
ukkodeveloper Sep 1, 2023
3031a54
feat: useFetch, useMutation react-hook 제거
ukkodeveloper Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions frontend/src/shared/hooks/useDebounceEffect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { renderHook, act } from '@testing-library/react-hooks';
import useDebounceEffect from './useDebounceEffect';

jest.useFakeTimers();

describe('useDebounceEffect 테스트. debounce 제한 딜레이를 0.5초로 둘 경우', () => {
Copy link
Collaborator

@Creative-Lee Creative-Lee Sep 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debounce 제한 딜레이를 0.5초로 둘 경우 이 부분은 아래 테스트 명으로 들어가야 될 것 같아요!

Copy link
Collaborator

@Creative-Lee Creative-Lee Sep 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의도 따로 확인했습니다 ㅎㅎ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 아래 경우에도 통과하고 있는데, 테스트를 어떻게 짜야할지 고민해봐야 할 것 같아요

  test('0.499초 지났을 때, 한 번도 실행되지 않는다.', () => {
    const fn = jest.fn();
    const { rerender } = renderHook(({ deps, delay }) => useDebounceEffect(fn, deps, delay), {
      initialProps: { deps: 'dependency1', delay: 500 },
    });

    expect(fn).not.toBeCalled();

    rerender({ deps: 'dependency2', delay: 5000 });

    act(() => {
      jest.advanceTimersByTime(4000);
    });

    rerender({ deps: 'dependency4', delay: 5000 });

    // 0ms
    expect(fn).not.toBeCalled();

    act(() => {
      jest.advanceTimersByTime(1000);
    });

    // 1000ms
    // fn이 실행되지 않아야 하는데 실행됨
    expect(fn).not.toBeCalled();
  });

test('0.499초 지났을 때, 한 번도 실행되지 않는다.', () => {
const fn = jest.fn();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 useFetch 테스트와 마찬가지로 beforeEach를 활용하면 좋을 것 같아요!

const { rerender } = renderHook(({ deps, delay }) => useDebounceEffect(fn, deps, delay), {
initialProps: { deps: 'dependency1', delay: 500 },
});

expect(fn).not.toBeCalled();

rerender({ deps: 'dependency2', delay: 500 });
rerender({ deps: 'dependency3', delay: 500 });
rerender({ deps: 'dependency4', delay: 500 });

act(() => {
jest.advanceTimersByTime(499);
});

expect(fn).not.toBeCalled();
});

test('0.5초 지났을 때, 한 번만 실행되지 않는다.', () => {
const fn = jest.fn();
const { rerender } = renderHook(({ deps, delay }) => useDebounceEffect(fn, deps, delay), {
initialProps: { deps: 'dependency1', delay: 500 },
});

expect(fn).not.toBeCalled();

rerender({ deps: 'dependency2', delay: 500 });
rerender({ deps: 'dependency3', delay: 500 });
rerender({ deps: 'dependency4', delay: 500 });

act(() => {
jest.advanceTimersByTime(500);
});

expect(fn).toBeCalledTimes(1);
});
});