[MVC 미션 1단계] 오션(김동해) 미션 제출합니다. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpot5620
approved these changes
Sep 14, 2023
Comment on lines
31
to
37
| public void initialize() { | ||
| log.info("Initialized AnnotationHandlerMapping!"); | ||
| final Reflections reflections = new Reflections(basePackage); | ||
|
|
||
| final Set<Class<?>> controllerClasses = reflections.getTypesAnnotatedWith(Controller.class); | ||
| controllerClasses.forEach(this::makeHandlerExecutions); | ||
| } |
There was a problem hiding this comment.
로그의 위치가 바뀌어야 하지 않을까요 ?
아래 코드가 수행되던 와중에, 예외가 발생하더라도 성공했다는 로그가 찍힐 것 같아요 ~
There was a problem hiding this comment.
그럴 것 같아요 ! 놓쳤던 부분이라 2단계에서 수정하겠습니다~
Comment on lines
+52
to
+57
| private Set<Method> getRequestMethod(final Class<?> controller) { | ||
| return Arrays.stream(controller.getDeclaredMethods()) | ||
| .filter(method -> !method.isSynthetic()) | ||
| .filter(method -> method.isAnnotationPresent(RequestMapping.class)) | ||
| .collect(Collectors.toSet()); | ||
| } |
There was a problem hiding this comment.
-
isSynthetic()을 통해 필터링 한 이유가 무엇인가요 ? -
추출한 메서드들의 파라미터 / 반환 타입 정도는 추가 검증해보는 것이 어떨까요 ?
-
Collectors.toList()를 사용해도 무방했을 것 같은데요. Set 자료구조를 사용하신 이유가 있을까요 ?
There was a problem hiding this comment.
- 모든 메소드를 가져오는 방식에서 애초에 Synthetic한 것만 가져와서 진행하려고 하였스빈다.
- getDeclaredMethods로 가져온 파라미터/반환 타입을 검증하자는 것일까요 ?
- 굳이 순서를 보장할 필요가 없다고 생각했고 O(1)으로 set이 탐색속도가 더빠르다고 생각했습니다.
Comment on lines
+76
to
+78
| private HandlerExecution getHandlerExecution(final Object instance, final Method method) { | ||
| return new HandlerExecution(instance, method); | ||
| } |
There was a problem hiding this comment.
굳이 필요없는 메소드 분리를 진행한 것 같네요 !
Comment on lines
80
to
84
| private void addHandlerExecution(final List<HandlerKey> handlerKeys, final HandlerExecution handlerExecution) { | ||
| for (HandlerKey handlerKey : handlerKeys) { | ||
| handlerExecutions.put(handlerKey, handlerExecution); | ||
| } | ||
| } |
There was a problem hiding this comment.
다른 코드에서 처럼, 여기서도 Collection의 forEach를 사용하는 것은 어떨까요 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 쥬니쥬니~
MVC 미션 1단계를 구현해보았습니다!
미리 쥬니의 빠르고 좋은 리뷰 감사합니다~