Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth API #38

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Auth API #38

wants to merge 16 commits into from

Conversation

karrirasinmaki
Copy link

I've been working with WP authentication and implementing it into this library.

I've been testing this in my own projects for a while now. Still, some work needs to be done before actually merging this into distribution.

Needs to be done:

  • Update documentation
  • Better token / session saving
  • Cleaning the code to fit the original project structure

@shprink
Copy link
Collaborator

shprink commented Feb 9, 2018

really nice work! Though for some reason your push 33 commits and I cannot merge it.

Can you try rebasing? also do not bump versions, I will do it.

thanks

@karrirasinmaki karrirasinmaki changed the base branch from develop to master February 9, 2018 21:30
@karrirasinmaki
Copy link
Author

Thanks! I think I created my branch originally from master. Changed the PR base branch according.

@karrirasinmaki
Copy link
Author

Oh, and couple things to note/ask:

  • In API class files (eq. src/Users.ts) there were interface code written. However, the same interface was defined in interfaces.ts, so I decided to import those interfaces from there and wrote those in a single place only. Was there some purpose of writing the same code in multiple places?
  • Updated angular libraries in package.json from ^4.0.0 to ^4.4.6. Might not be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants