Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3843 Add Lazyrender Content feature #6916

Merged
merged 217 commits into from
Sep 16, 2024
Merged

Closes #3843 Add Lazyrender Content feature #6916

merged 217 commits into from
Sep 16, 2024

Conversation

wordpressfan
Copy link
Contributor

@wordpressfan wordpressfan commented Aug 27, 2024

Description

Fixes #3843
Explain how this code impacts users.

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Release

Detailed scenario

https://www.notion.so/wpmedia/Lazy-render-content-bf707b5f731a426cb5d1294beb770540?pvs=4

Technical description

Documentation

https://www.notion.so/wpmedia/Lazy-Render-Content-LRC-7de60c101f0344f2a6280dd2e0f019c2?pvs=4

New dependencies

DOMDocument

Risks

NA

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

transifex-integration bot and others added 30 commits May 7, 2024 18:40
100% translated source file: 'languages/rocket.pot'
on 'pt_BR'.
100% translated source file: 'languages/rocket.pot'
on 'fa_IR'.
100% translated source file: 'languages/rocket.pot'
on 'fr_FR'.
100% translated source file: 'languages/rocket.pot'
on 'fr_FR'.
100% translated source file: 'languages/rocket.pot'
on 'fr_FR'.
Co-authored-by: WordPressFan <ahmed@wp-media.me>
Co-authored-by: Opeyemi Ibrahim <opeyemi.khadri@gmail.com>
@remyperona remyperona added this to the 3.17 milestone Sep 11, 2024
package.json Outdated Show resolved Hide resolved
@remyperona remyperona changed the title LRC functionality Closes #3843 Add Lazyrender Content feature Sep 11, 2024
@remyperona remyperona added the type: new feature Indicates the issue is a request for new functionality label Sep 11, 2024
transifex-integration bot and others added 17 commits September 11, 2024 16:41
100% translated source file: 'languages/rocket.pot'
on 'tr_TR'.
100% translated source file: 'languages/rocket.pot'
on 'tr_TR'.
100% translated source file: 'languages/rocket.pot'
on 'pt_PT'.
100% translated source file: 'languages/rocket.pot'
on 'pt_PT'.
100% translated source file: 'languages/rocket.pot'
on 'tr_TR'.
100% translated source file: 'languages/rocket.pot'
on 'tr_TR'.
100% translated source file: 'languages/rocket.pot'
on 'tr_TR'.
100% translated source file: 'languages/rocket.pot'
on 'fa_IR'.
100% translated source file: 'languages/rocket.pot'
on 'fr_FR'.
100% translated source file: 'languages/rocket.pot'
on 'fr_FR'.
@wordpressfan wordpressfan marked this pull request as ready for review September 16, 2024 11:20
@wordpressfan wordpressfan added this pull request to the merge queue Sep 16, 2024
Merged via the queue into develop with commit 4b9193b Sep 16, 2024
11 of 14 checks passed
@wordpressfan wordpressfan deleted the feature/lrc branch September 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new feature Indicates the issue is a request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyLoad Content
6 participants