Skip to content

Fixes #6953 LRC replace DOM output with regex injection (#6954)

Codacy Production / Codacy Static Code Analysis required action Sep 11, 2024 in 0s

6 new issues (1 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 6
           

Complexity increasing per file
==============================
- inc/Engine/Optimization/LazyRenderContent/Factory.php  1
- inc/Engine/Optimization/LazyRenderContent/Database/Queries/LazyRenderContent.php  3
- inc/Engine/Optimization/LazyRenderContent/Database/Rows/LazyRenderContent.php  4
- inc/Engine/Optimization/LazyRenderContent/AJAX/Controller.php  11
- inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Processor.php  4
- inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/SimpleHtmlDom.php  5
- inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Regex.php  4
- inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Dom.php  9
- inc/Engine/Common/PerformanceHints/Admin/Notices.php  4
- inc/Engine/Common/PerformanceHints/AJAX/Processor.php  2
- inc/Engine/Common/PerformanceHints/Admin/Clean.php  3
- inc/Engine/Common/PerformanceHints/Admin/AdminBar.php  2
- inc/Engine/Optimization/LazyRenderContent/Frontend/Subscriber.php  1
- inc/Engine/Optimization/LazyRenderContent/Frontend/Controller.php  4
- inc/Engine/Optimization/LazyRenderContent/ServiceProvider.php  1
- inc/Engine/Optimization/LazyRenderContent/Context/Context.php  2
- inc/Engine/Optimization/LazyRenderContent/Activation/ActivationFactory.php  1
- inc/Engine/Common/PerformanceHints/Frontend/Subscriber.php  2
- inc/Engine/Common/PerformanceHints/Activation/ServiceProvider.php  1
- inc/Engine/Common/PerformanceHints/ServiceProvider.php  1
- inc/classes/class-abstract-render.php  1
         

Complexity decreasing per file
==============================
+ inc/Engine/Common/PerformanceHints/WarmUp/Controller.php  -1
+ inc/Engine/Common/PerformanceHints/AJAX/Subscriber.php  -1
+ inc/Engine/Saas/Admin/Clean.php  -5
+ inc/Engine/Saas/Admin/AdminBar.php  -4
+ inc/Engine/Media/ImageDimensions/Subscriber.php  -1
         

Clones added
============
- inc/Engine/Optimization/LazyRenderContent/Database/Schema/LazyRenderContent.php  1
         

See the complete overview on Codacy

Annotations

Check warning on line 56 in inc/Engine/Media/AboveTheFold/AJAX/Controller.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

inc/Engine/Media/AboveTheFold/AJAX/Controller.php#L56

The method add_data() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.

Check warning on line 56 in inc/Engine/Media/AboveTheFold/AJAX/Controller.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

inc/Engine/Media/AboveTheFold/AJAX/Controller.php#L56

The method add_data() has an NPath complexity of 56064. The configured NPath complexity threshold is 200.

Check warning on line 46 in inc/Engine/Optimization/LazyRenderContent/AJAX/Controller.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

inc/Engine/Optimization/LazyRenderContent/AJAX/Controller.php#L46

The method add_data() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.

Check warning on line 46 in inc/Engine/Optimization/LazyRenderContent/AJAX/Controller.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

inc/Engine/Optimization/LazyRenderContent/AJAX/Controller.php#L46

The method add_data() has an NPath complexity of 1536. The configured NPath complexity threshold is 200.

Check warning on line 15 in inc/Engine/Optimization/LazyRenderContent/Context/Context.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

inc/Engine/Optimization/LazyRenderContent/Context/Context.php#L15

Avoid unused parameters such as '$data'.

Check warning on line 80 in inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Dom.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

inc/Engine/Optimization/LazyRenderContent/Frontend/Processor/Dom.php#L80

The method add_hash_to_element() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.