Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use harmonized s2 #62

Merged
merged 1 commit into from
Aug 26, 2024
Merged

update to use harmonized s2 #62

merged 1 commit into from
Aug 26, 2024

Conversation

weiqi-tori
Copy link
Member

@S-AI-F
Copy link
Member

S-AI-F commented Aug 21, 2024

Looks good for me. @kcartier-wri can you check and approve if it is ok?

@kcartier-wri
Copy link
Contributor

Looks good and thanks for addressing this so quickly. :) BTW, I confirmed that running the code for a period of time before the January 24th 2022 date, mentioned in the GEE article, does return results.

Moving forward we'll need to use the harmonized version on new layers, such as for NDVI.

@S-AI-F - How does this affect notebooks? Do they need to be updated as well and updated results written out to the WorldResources AWS account?

@S-AI-F
Copy link
Member

S-AI-F commented Aug 22, 2024

@kcartier-wri We don't need to update the notebook. We are not planning to maintain them or ruse them The goal is to move all the notebooks into the new framework structure. We should keep them as they are to know how we obtained the old results. We are planning to update the technical note to redirect to the new cif github once all indicators and metrics are implemented.

@weiqi-tori weiqi-tori merged commit b3f7f4c into main Aug 26, 2024
1 check passed
@weiqi-tori weiqi-tori deleted the fix/harmonized_s2 branch August 26, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants