Cif 197 core resolution option for layer downloads #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test_layer_parameters in a manner intended to improve ease of code maintenance.
|
I implemented the test_layer_parameters test in a manner that will simplify addition of other layer classes in the future. This solution follows the goal of making CIF as self-maintainable as possible by data scientists. |
…ttps://github.com/wri/cities-cif into CIF-197-CORE-Resolution-option-for-layer-downloads
|
Change summary:
|
jterry64
approved these changes
Sep 4, 2024
|
@jterry64 - In particular, could you carefully review the spatial_resolution implementation in HighLandSurfaceTemperature? |
kcartier-wri
requested review from
jterry64 and
chrowe
and removed request for
jterry64 and
chrowe
jterry64
requested changes
Sep 5, 2024
jterry64
approved these changes
Sep 6, 2024
kcartier-wri
deleted the
CIF-197-CORE-Resolution-option-for-layer-downloads
branch
chrowe
reviewed
Sep 9, 2024
| Attributes: | ||
| start_date: starting date for data retrieval | ||
| end_date: ending date for data retrieval | ||
| spatial_resolution: raster resolution in meters (see https://github.com/stac-extensions/raster) |
There was a problem hiding this comment.
Is there a reason you added (see https://github.com/stac-extensions/raster) to all of theses and not just the ones that use a stac catalog?
| @@ -16,5 +16,6 @@ geemap==0.32.0 | |||
| pip==23.3.1 | |||
| boto3==1.34.124 | |||
| scikit-learn==1.5.1 | |||
| scikit-image==0.24.0 | |||
There was a problem hiding this comment.
What are we using scikit-image for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this PR related to a JIRA ticket?
https://gfw.atlassian.net/browse/CIF-197
What changes were proposed in this PR?
Allow control of spatial resolution of raster layers.
How was this patch tested?
Locally on MS WSL
Did this PR include necessary documentation updates?