Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev_ci_cd.yml #71

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Update dev_ci_cd.yml #71

merged 1 commit into from
Sep 3, 2024

Conversation

chrowe
Copy link
Contributor

@chrowe chrowe commented Sep 3, 2024

@chrowe chrowe requested a review from kcartier-wri September 3, 2024 19:59
kcartier-wri
kcartier-wri reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@kcartier-wri kcartier-wri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the change to actions/checkout@v4 based on GitHub documentation. Why is the change to setup-python@v5 also necessary?

kcartier-wri
kcartier-wri approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@kcartier-wri kcartier-wri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on our discussion.

@chrowe chrowe merged commit d37b79c into main Sep 3, 2024
1 check passed
@chrowe chrowe deleted the node20 branch September 3, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcartier-wri kcartier-wri kcartier-wri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrowe @kcartier-wri