Feature/transit stops osm

[weiqi-tori]

https://gfw.atlassian.net/browse/CIF-212

[tedw0ng]

Please also add these values to 'railway': 'subway_entrance', 'station'

[weiqi-tori]

Please also add these values to 'railway': 'subway_entrance', 'station'

Gotcha, added

[kcartier-wri]

If possible, it may be worthwhile adding a docstring to the OpenStreetMapClass that describes the high-level criteria for including the specific OSM features in the class. What is the underlying goal. Is it simply that the Data Scientists have requested these specific features or are we trying to produce a “base map” of some sort toward some goal? This would allow us to determine if the set is complete.

For example, given that wetlands are a critical environmental landform, why are we not currently specifying ‘natural’:[wetland’] under water?

Is there an internal page that describes how we decide which features to include and why?

It may also be useful to include a pointer to the OSM features page Map features - OpenStreetMap Wiki

Thanks Tori.

[S-AI-F]

The OSM features are used for calculating the indicators that are served in the dashboard and not for basemap (fir this case). For exemple, 'open space' and 'health sites' are used for calculating proximity to open space areas or health service. The indicators methods are defined in the technical note used for this work. Agree that we might probably have documentation or links to the published technical in the code base.

[S-AI-F]

The tech note describinh the indicator methids and how the layers are defined: https://www.wri.org/research/calculating-indicators-global-geospatial-datasets-urban-environment

[S-AI-F]

We are adding a new ticket for documenting the layers classes and selected methods

[chrowe]

Looks good to me

Requested changes were made