-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLAG-879] Implement new metadata endpoint #4791
Open
willian-viana
wants to merge
23
commits into
develop
Choose a base branch
from
feat/new-metadata-endpoint-FLAG-879
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wri7tno
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I see the commented code that will replace the hardcoded url and dataset 👍
willian-viana
force-pushed
the
feat/new-metadata-endpoint-FLAG-879
branch
from
July 2, 2024 14:42
7e4a50e
to
0ba4cb4
Compare
willian-viana
force-pushed
the
feat/new-metadata-endpoint-FLAG-879
branch
from
September 9, 2024 14:34
0ba4cb4
to
aad521c
Compare
willian-viana
force-pushed
the
feat/new-metadata-endpoint-FLAG-879
branch
from
September 25, 2024 17:26
9f878e7
to
57e04fd
Compare
willian-viana
force-pushed
the
feat/new-metadata-endpoint-FLAG-879
branch
from
September 25, 2024 20:44
57e04fd
to
56218c8
Compare
willian-viana
force-pushed
the
feat/new-metadata-endpoint-FLAG-879
branch
from
September 25, 2024 21:25
56218c8
to
453380f
Compare
willian-viana
force-pushed
the
feat/new-metadata-endpoint-FLAG-879
branch
from
December 10, 2024 16:05
b94874b
to
b5aa6e0
Compare
…while we update metadata for layers
For testing purposes I set the dataset and the version as hardcoded We will remove it as soon as the test get finished
some datasets are not on Data API, for that reason we are still requesting RW API for a few cases
…properties We have three different properties to display the content date: content_date_description, content_date_range, and content_date, in this order of priority.
We won't use this property anymore
willian-viana
force-pushed
the
feat/new-metadata-endpoint-FLAG-879
branch
from
December 17, 2024 19:40
544015f
to
71a2c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
An overarching explanation of this task can be found on this Miro board:
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing