Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve lint warnings #79

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Resolve lint warnings #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d49f22
Suppress custom TLS trust manager warning
TomasKypta Nov 8, 2023
03a1128
Update obsolete dependency
TomasKypta Nov 8, 2023
5858d42
Disable obsolete custom lint checks
TomasKypta Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion library/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ android {
withJavadocJar()
}
}

lintOptions {
// to handle warning coming from a transitive dependency
// - obsolete 'androidx.fragment' through 'powerauth-sdk'
disable 'ObsoleteLintCustomCheck'
}
}

dependencies {
Expand All @@ -66,7 +72,7 @@ dependencies {

implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"
implementation "com.google.code.gson:gson:${gsonVersion}"
implementation "androidx.annotation:annotation:1.6.0"
implementation "androidx.annotation:annotation:1.7.0"

testImplementation "com.wultra.android.powerauth:powerauth-sdk:${powerAuthSdkVersion}"
testImplementation 'junit:junit:4.13.2'
Expand Down
1 change: 1 addition & 0 deletions library/src/main/java/com/wultra/android/sslpinning/SslValidationStrategy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ abstract class SslValidationStrategy {
* Implements SSL validation strategy that trust any server certificate.
* See [SslValidationStrategy.noValidation] for more details.
*/
@Suppress("CustomX509TrustManager")
internal class NoSslValidationStrategy: SslValidationStrategy() {
override fun sslSocketFactory(): SSLSocketFactory? {
val trustAllCerts = Array(1) { object : X509TrustManager {
Expand Down
1 change: 1 addition & 0 deletions ...ary/src/main/java/com/wultra/android/sslpinning/integration/SSLPinningX509TrustManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import javax.net.ssl.X509TrustManager
*
* @author Tomas Kypta, tomas.kypta@wultra.com
*/
@Suppress("CustomX509TrustManager")
class SSLPinningX509TrustManager(private val certStore: CertStore) : X509TrustManager {

@SuppressLint("TrustAllX509TrustManager")
Expand Down