Skip to content

Commit

Permalink
Merge pull request #10 from ww24/fix-ingress
Browse files Browse the repository at this point in the history
fix: fix run.googleapis.com/ingress
  • Loading branch information
ww24 authored May 27, 2021
2 parents f646c7f + 8e17a5b commit 8cbac88
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 32 deletions.
56 changes: 28 additions & 28 deletions terraform/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions terraform/cloud_run.tf
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ resource "google_cloud_run_service" "gateway" {
annotations = {
"autoscaling.knative.dev/maxScale" = "1"

# not working (2021/05/12)
"run.googleapis.com/ingress" = "internal-and-cloud-load-balancing"
# not working (2021/05/27)
"run.googleapis.com/ingress" = "all"
}

labels = {
Expand Down
4 changes: 2 additions & 2 deletions terraform/terraform.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = "~> 3.67.0"
version = "~> 3.69.0"
}

google-beta = {
source = "hashicorp/google-beta"
version = "~> 3.67.0"
version = "~> 3.69.0"
}
}

Expand Down

0 comments on commit 8cbac88

Please sign in to comment.