disasm: fix pltgottargets handling when no matches are found #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you specify sep when splitting a string but the sep value isn't found, you get a list with a single entry that is an empty string. More generally, consecutive delimiters aren't grouped together and are deemed to delimit empty strings. An empty string is an invalid argument for the pltgotmapper function, so filter them out.
|
I'd also like to use this opportunity to ask if |
|
Thanks for your PR. I think gcc-4.8 isn't really needed for recompile the diversified binaries. But you may encounter some undefined behaviors due to changes in the compiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this problem on a Debian 10 (buster) system -- because of how Python's string
splitmethod works, an empty string was being passed topltgotmapperwhen no matches were actually found. Obviously this caused problems when trying to split the line and index inside the function.It's possible the same problem may exist elsewhere, e.g., right above when mapping into the
pltsymmapperfunction. You might consider also fixing these potential problems.Thanks.