Add ability to upload mappings/symbols file #26
Conversation
| appName: ${{ secrets.IOS_APP_NAME }} | ||
| token: ${{ secrets.IOS_API_TOKEN }} |
There was a problem hiding this comment.
iOS apps cannot be uploaded to the same project as android ones
| RUN wget -q "https://dl.google.com/dl/android/maven2/com/android/tools/build/aapt2/4.0.1-6197926/aapt2-4.0.1-6197926-linux.jar" -O aapt2-all.jar \ | ||
| && mv aapt2-all.jar /usr/local/lib/aapt/aapt2-all.jar \ | ||
| && cd /usr/local/lib/aapt \ | ||
| && unzip -qq aapt2-all.jar \ | ||
| && ln -s /usr/local/lib/aapt/aapt2 /usr/local/bin/aapt2 |
There was a problem hiding this comment.
According to the [documentation(https://developer.android.com/studio/command-line/aapt2#download_aapt2) to use aapt it is required to download the jar and extract it. The jar itself isn't executable 🤷
There was a problem hiding this comment.
Another thing here is the location where the jar file is extracted to.
I could extract the file into the working directory as it gets bound as a volume (which makes me thinking if COPY . /app is actually needed if all the content gets immediately ovewritten 🤔)
There was a problem hiding this comment.
And one more thing is that I'm creating a symlink on a path that belongs to PATH as I wanted to make it executable everywhere, but for some reason I couldn't make it to work 🤷 If anyone has any idea why it didn't work in the bash script I'd love to know.
README.md
Outdated
| @@ -9,7 +9,7 @@ This action uploads artifacts (.apk or .ipa) to Visual Studio App Center. | |||
|
|
|||
| ### `appName` | |||
|
|
|||
| **Required** App name followed by username e.g. `wzieba/Sample-App` | |||
| **Required** App name preceded by the App Center's username e.g. wzieba/Sample-App | |||
There was a problem hiding this comment.
it wasn't clear for me what the username is. I have an account created using google sign in so in my case there was some.weirdshit-domaincom. I thought it might make sense to update the documentation here as well
mateuszkwiecinski
changed the title
Fixes #12
An attempt to include mappings/symbols file on action run