Create Fibonaaci.c #81
Conversation
Reviewer's Guide by SourceryThis PR adds a new C program that implements the Fibonacci sequence calculation. The implementation uses an iterative approach with three variables to track the sequence progression and prints the sequence up to a user-specified number of terms. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @o10a19 - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Check scanf return value to prevent buffer overflow risks (link)
Overall Comments:
- The filename 'Fibonaaci.c' contains a typo - it should be 'Fibonacci.c'
- main() should return int, not void, to comply with the C standard
- Consider adding input validation to handle negative numbers and zero gracefully
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -0,0 +1,13 @@ | |||
| #include <stdio.h> | |||
| void main(){ | |||
There was a problem hiding this comment.
issue: main() should return int as per C standard
| void main(){ | ||
| int n,a=0,b=1,c,i; | ||
| printf("Enter a number"); | ||
| scanf("%d",&n); |
There was a problem hiding this comment.
🚨 issue (security): Check scanf return value to prevent buffer overflow risks
Always verify scanf's return value to ensure input was successfully read
| int n,a=0,b=1,c,i; | ||
| printf("Enter a number"); | ||
| scanf("%d",&n); | ||
| for(i=1;i<=n;i++) |
There was a problem hiding this comment.
issue: Handle edge cases for n=0 and n=1 correctly
Summary by Sourcery
New Features: