Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR]: Enable skipna for spatial and temporal mean operations #655

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[PR]: Enable skipna for spatial and temporal mean operations #655

wants to merge 11 commits into from

Commits on Nov 6, 2024

  1. add skipna parameter

    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bb2f375 View commit details
    Browse the repository at this point in the history

  2. add skipna parameter

    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    24951ec View commit details
    Browse the repository at this point in the history

  3. add skipna where it was missed

    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    534ad4b View commit details
    Browse the repository at this point in the history

  4. add parameter documentation

    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8b4536a View commit details
    Browse the repository at this point in the history

  5. make sure time diff type is timedelta: convert timedelta64 to timedel… 

    …ta in such case
    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b7bfc36 View commit details
    Browse the repository at this point in the history

  6. Use Union for skipna to allow bool or None, instead of using | op… 

    …erator that fails CI build for python 3.9
    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c4545ba View commit details
    Browse the repository at this point in the history

  7. Use Union for skipna to allow bool or None, instead of using | op… 

    …erator that fails CI build for python 3.9 (fixing those missed in the previous commit)
    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    826a7f1 View commit details
    Browse the repository at this point in the history

  8. retract the change for timedelta conversion to make a separate PR

    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f74699c View commit details
    Browse the repository at this point in the history

  9. Add skipna arg to all temporal APIs 

    - Add unit tests
    @tomvothecoder
    tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9c4aa48 View commit details
    Browse the repository at this point in the history

  10. Add annotations import to temporal.py

    @tomvothecoder
    tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    67377ce View commit details
    Browse the repository at this point in the history

  11. Restore code in bounds.py that was accidentally deleted

    @tomvothecoder
    tomvothecoder committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b770b91 View commit details
    Browse the repository at this point in the history