Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cosmetic changes #72

Merged
merged 11 commits into from
Aug 5, 2023
Merged

chore: cosmetic changes #72

merged 11 commits into from
Aug 5, 2023

Conversation

nicrie
Copy link
Contributor

@nicrie nicrie commented Aug 5, 2023

  • add solver_kwargs parameter to models; now parameters can be specified for the underlying SVD solver of each model
  • enforce Black coding style

nicrie and others added 11 commits August 3, 2023 00:04
pre-hooks and GitHub Actions will use Black.
use Black default settings
before only specific parameter were allowed.
Now one can set any parameter available in the given solver.
needed for the Github Action to run black successfully
New structure separates workflows into
separate workflows: ci, PR linting, black formatting and creating
release. The latter is only triggered
after a PR has been merged. All others are triggered when
a PR on main/develop is opened, edited or synchronized.
Black linted all files in repo including examples. Main folder xeofs
is sufficient though.
ci: update Github Action workflows
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2023

Codecov Report

Merging #72 (7e679bc) into main (58ae844) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 96.97%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   97.17%   97.17%   -0.01%     
==========================================
  Files          63       65       +2     
  Lines        4351     4382      +31     
==========================================
+ Hits         4228     4258      +30     
- Misses        123      124       +1     
Files Changed Coverage Δ
xeofs/utils/constants.py 100.00% <ø> (ø)
xeofs/preprocessing/_base_stacker.py 73.91% <50.00%> (ø)
.../data_container/eof_bootstrapper_data_container.py 92.85% <66.66%> (ø)
xeofs/utils/rotation.py 88.67% <77.77%> (ø)
xeofs/preprocessing/scaler.py 91.40% <82.35%> (ø)
xeofs/preprocessing/stacker.py 93.00% <84.00%> (ø)
xeofs/utils/xarray_utils.py 92.53% <84.61%> (ø)
xeofs/data_container/mca_rotator_data_container.py 93.22% <85.71%> (ø)
xeofs/utils/statistics.py 68.00% <85.71%> (ø)
xeofs/data_container/_base_model_data_container.py 92.15% <87.50%> (ø)
... and 55 more

@nicrie nicrie merged commit 9f44357 into main Aug 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants