Update dependency requests to v2.32.2 [SECURITY] #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==2.25.1->==2.32.2GitHub Vulnerability Alerts
CVE-2023-32681
Impact
Since Requests v2.3.0, Requests has been vulnerable to potentially leaking
Proxy-Authorizationheaders to destination servers, specifically during redirects to an HTTPS origin. This is a product of howrebuild_proxiesis used to recompute and reattach theProxy-Authorizationheader to requests when redirected. Note this behavior has only been observed to affect proxied requests when credentials are supplied in the URL user information component (e.g.https://username:password@proxy:8080).Current vulnerable behavior(s):
For HTTP connections sent through the proxy, the proxy will identify the header in the request itself and remove it prior to forwarding to the destination server. However when sent over HTTPS, the
Proxy-Authorizationheader must be sent in the CONNECT request as the proxy has no visibility into further tunneled requests. This results in Requests forwarding the header to the destination server unintentionally, allowing a malicious actor to potentially exfiltrate those credentials.The reason this currently works for HTTPS connections in Requests is the
Proxy-Authorizationheader is also handled by urllib3 with our usage of the ProxyManager in adapters.py withproxy_manager_for. This will compute the required proxy headers inproxy_headersand pass them to the Proxy Manager, avoiding attaching them directly to the Request object. This will be our preferred option going forward for default usage.Patches
Starting in Requests v2.31.0, Requests will no longer attach this header to redirects with an HTTPS destination. This should have no negative impacts on the default behavior of the library as the proxy credentials are already properly being handled by urllib3's ProxyManager.
For users with custom adapters, this may be potentially breaking if you were already working around this behavior. The previous functionality of
rebuild_proxiesdoesn't make sense in any case, so we would encourage any users impacted to migrate any handling of Proxy-Authorization directly into their custom adapter.Workarounds
For users who are not able to update Requests immediately, there is one potential workaround.
You may disable redirects by setting
allow_redirectstoFalseon all calls through Requests top-level APIs. Note that if you're currently relying on redirect behaviors, you will need to capture the 3xx response codes and ensure a new request is made to the redirect destination.Credits
This vulnerability was discovered and disclosed by the following individuals.
Dennis Brinkrolf, Haxolot (https://haxolot.com/)
Tobias Funke, (tobiasfunke93@gmail.com)
CVE-2024-35195
When making requests through a Requests
Session, if the first request is made withverify=Falseto disable cert verification, all subsequent requests to the same origin will continue to ignore cert verification regardless of changes to the value ofverify. This behavior will continue for the lifecycle of the connection in the connection pool.Remediation
Any of these options can be used to remediate the current issue, we highly recommend upgrading as the preferred mitigation.
requests>=2.32.0.requests<2.32.0, avoid settingverify=Falsefor the first request to a host while using a Requests Session.requests<2.32.0, callclose()onSessionobjects to clear existing connections ifverify=Falseis used.Related Links
Release Notes
psf/requests (requests)
v2.32.2Compare Source
Deprecations
To provide a more stable migration for custom HTTPAdapters impacted
by the CVE changes in 2.32.0, we've renamed
_get_connectiontoa new public API,
get_connection_with_tls_context. Existing customHTTPAdapters will need to migrate their code to use this new API.
get_connectionis considered deprecated in all versions of Requests>=2.32.0.A minimal (2-line) example has been provided in the linked PR to ease
migration, but we strongly urge users to evaluate if their custom adapter
is subject to the same issue described in CVE-2024-35195. (#6710)
v2.32.1Compare Source
Bugfixes
v2.32.0Compare Source
Security
verify=Falseon the first request from aSession will cause subsequent requests to the same origin to also ignore
cert verification, regardless of the value of
verify.(GHSA-9wx4-h78v-vm56)
Improvements
verify=Truenow reuses a global SSLContext which should improverequest time variance between first and subsequent requests. It should
also minimize certificate load time on Windows systems when using a Python
version built with OpenSSL 3.x. (#6667)
(
chardetorcharset_normalizer) when repackaged or vendored.This enables
pipand other projects to minimize their vendoringsurface area. The
Response.text()andapparent_encodingAPIswill default to
utf-8if neither library is present. (#6702)Bugfixes
calculated in the request content-length. (#6589)
/(path separator) could leadurllib3 to unnecessarily reparse the request URI. (#6644)
Deprecations
Documentation
Packaging
The source files for the projects (formerly
requests) is now locatedin
src/requestsin the Requests sdist. (#6506)using
hatchling. This should not impact the average user, but extremely oldversions of packaging utilities may have issues with the new packaging format.
v2.31.0Compare Source
Security
Versions of Requests between v2.3.0 and v2.30.0 are vulnerable to potential
forwarding of
Proxy-Authorizationheaders to destination servers whenfollowing HTTPS redirects.
When proxies are defined with user info (
https://user:pass@proxy:8080), Requestswill construct a
Proxy-Authorizationheader that is attached to the request toauthenticate with the proxy.
In cases where Requests receives a redirect response, it previously reattached
the
Proxy-Authorizationheader incorrectly, resulting in the value beingsent through the tunneled connection to the destination server. Users who rely on
defining their proxy credentials in the URL are strongly encouraged to upgrade
to Requests 2.31.0+ to prevent unintentional leakage and rotate their proxy
credentials once the change has been fully deployed.
Users who do not use a proxy or do not supply their proxy credentials through
the user information portion of their proxy URL are not subject to this
vulnerability.
Full details can be read in our Github Security Advisory
and CVE-2023-32681.
v2.30.0Compare Source
Dependencies
This may contain minor breaking changes so we advise careful testing and
reviewing https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html
prior to upgrading.
Users who wish to stay on urllib3 1.x can pin to
urllib3<2.v2.29.0Compare Source
Improvements
standardization. (#6226)
v2.28.2Compare Source
Dependencies
Bugfixes
v2.28.1Compare Source
Improvements
iter_contentwith transition toyield from. (#6170)Dependencies
v2.28.0Compare Source
Deprecations
Improvements
an encoding to make
json()API consistent. (#6097)all invalid cases. (#6154)
Bugfixes
CURL_CA_BUNDLEto an empty string would disablecert verification. All Requests 2.x versions before 2.28.0 are affected. (#6074)
urllib3.exceptions.SSLErrorwithrequests.exceptions.SSLErrorforcontentanditer_content. (#6057)to raise an exception rather than ignoring the entry. (#6149)
JSONDecodeError. (#6036)
v2.27.1Compare Source
Bugfixes
authcomponent beingdropped from proxy URLs. (#6028)
v2.27.0Compare Source
Improvements
Officially added support for Python 3.10. (#5928)
Added a
requests.exceptions.JSONDecodeErrorto unify JSON exceptions betweenPython 2 and 3. This gets raised in the
response.json()method, and isbackwards compatible as it inherits from previously thrown exceptions.
Can be caught from
requests.exceptions.RequestExceptionas well. (#5856)Improved error text for misnamed
InvalidSchemaandMissingSchemaexceptions. This is a temporary fix until exceptions can be renamed
(Schema->Scheme). (#6017)
Improved proxy parsing for proxy URLs missing a scheme. This will address
recent changes to
urlparsein Python 3.9+. (#5917)Bugfixes
Fixed defect in
extract_zipped_pathswhich could result in an infinite loopfor some paths. (#5851)
Fixed handling for
AttributeErrorwhen calculating length of files obtainedby
Tarfile.extractfile(). (#5239)Fixed urllib3 exception leak, wrapping
urllib3.exceptions.InvalidHeaderwithrequests.exceptions.InvalidHeader. (#5914)Fixed bug where two Host headers were sent for chunked requests. (#5391)
Fixed regression in Requests 2.26.0 where
Proxy-Authorizationwasincorrectly stripped from all requests sent with
Session.send. (#5924)Fixed performance regression in 2.26.0 for hosts with a large number of
proxies available in the environment. (#5924)
Fixed idna exception leak, wrapping
UnicodeErrorwithrequests.exceptions.InvalidURLfor URLs with a leading dot (.) in thedomain. (#5414)
Deprecations
don't have exact dates, Requests 2.27.x is likely to be the last release
series providing support.
v2.26.0Compare Source
Improvements
Requests now supports Brotli compression, if either the
brotliorbrotlicffipackage is installed. (#5783)Session.sendnow correctly resolves proxy configurations from boththe Session and Request. Behavior now matches
Session.request. (#5681)Bugfixes
from zip archive. (#5707)
Dependencies
Instead of
chardet, use the MIT-licensedcharset_normalizerfor Python3to remove license ambiguity for projects bundling requests. If
chardetis already installed on your machine it will be used instead of
charset_normalizerto keep backwards compatibility. (#5797)
You can also install
chardetwhile installing requests byspecifying
[use_chardet_on_py3]extra as follows:pip install "requests[use_chardet_on_py3]"Python2 still depends upon the
chardetmodule.Requests now supports
idna3.x on Python 3.idna2.x will continue tobe used on Python 2 installations. (#5711)
Deprecations
The
requests[security]extra has been converted to a no-op install.PyOpenSSL is no longer the recommended secure option for Requests. (#5867)
Requests has officially dropped support for Python 3.5. (#5867)
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.