Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedisConnection doesn't need to call IsConnection() #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RedisConnection doesn't need to call IsConnection() #34

wants to merge 1 commit into from

Conversation

nobnak
Copy link

@nobnak nobnak commented May 6, 2021

StackExchange.Redis automatically reconnect when connection is lost. So it's not needed to check if it's connected or not.

It's also better to keep same ConnectionMultiplexer for working with Pub/Sub API.

@xin9le xin9le requested review from xin9le and neuecc May 7, 2021 13:35
@xin9le
Copy link
Owner

xin9le commented May 7, 2021 •
edited
Loading

Thank you for good PR.
However your PR has conflict, could you please resolve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xin9le xin9le Awaiting requested review from xin9le

@neuecc neuecc Awaiting requested review from neuecc

Assignees

@nobnak nobnak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nobnak @xin9le