Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21842: The search bar takes too much width when folded #2832

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jan 31, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21842

Changes

Description

  • Replaced the ScaleX transition with a width + padding one.

Clarifications

  • This is a heavier implementation because layout needs to be recalculated multiple times (at multiple ), but we actually want layout to move around depending on the state of the search toggle, so it's worth it.

Screenshots & Video

Here is a demo of the changes brought in this PR, highlighted by following the steps described in the ticket.

Executed Tests

No maven command ran. Changes are only styles. Moreover, this is a followup on https://github.com/xwiki/xwiki-platform/pull/2163/files, which did not change any tests beyond some webstandards (#2193, unrelated to the changes in this PR).

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.X because the regression got introduced in 15.5 and this fix is very safe.

* Replaced the ScaleX transition with a width + padding one.

Note: This is a heavier implementation because layout needs to be recalculated multiple times, but we actually want layout to move around depending on the state of the search toggle, so it's worth it.
@Sereza7 Sereza7 added the backport stable-15.10.x Used for automatic backport to 15.10.x branch. label Feb 1, 2024
@surli surli merged commit c1cf1a1 into xwiki:master Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants