PNPM Experiment #2880
Open
PNPM Experiment #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelleduc
commented
Feb 13, 2024
| @@ -0,0 +1,2 @@ | |||
| packages: | |||
| - "./**/src/main/node" | |||
There was a problem hiding this comment.
Any project containing a src/main/node directory is considered as a pnpm package.
manuelleduc
commented
Feb 13, 2024
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.xwiki.platform</groupId> | ||
| <artifactId>xwiki-platform-lib-a</artifactId> |
There was a problem hiding this comment.
Runtime dependency to lib-a for the webjar level.
As of now, I don't think we have a better solution than to manually maintain modules dependencies at maven and npm levels (i.e., so code duplication).
manuelleduc
force-pushed
the
pnpm-experiment
branch
from
bb6618a
to
772d7f4
Compare
manuelleduc
force-pushed
the
pnpm-experiment
branch
from
772d7f4
to
2b7d956
Compare
* remove unrelated file * fix typo in package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Description
Demo of the use of xwiki/xwiki-commons#772 in
xwiki-platformTwo
webjar-nodemodules are defined,xwiki-platform-lib-aandxwiki-platform-lib-b.xwiki-platform-lib-bdepends onxwiki-platform-lib-a.Both projects are defined using typescript and are type checked.
This PR is currently mainly a support for the forum proposal that will follow.