XWIKI-22211: Deprecate NotificationFilterPreferenceProvider #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
force-pushed
the
break-notification-filter-provider
branch
2 times, most recently
from
7fd885e
to
07020d9
Compare
surli
commented
Feb 13, 2024
...g/xwiki/notifications/filters/internal/scope/ScopeNotificationFilterExpressionGenerator.java
Outdated
Show resolved
Hide resolved
surli
force-pushed
the
break-notification-filter-provider
branch
3 times, most recently
from
64f29be
to
5c2e4ff
Compare
* Deprecate and legacify NotificationFilterPreferenceProvider and
NotificationFilterPreference#getProviderHint
* Clean up all code relying on it simplifying a lot the implem of
NotificationFilterPreference
* Only valid usage of the providerHint was for checking if a filter
preference was stored or not: replaced it with checking the ID of
the filter
surli
force-pushed
the
break-notification-filter-provider
branch
from
5c2e4ff
to
670780f
Compare
surli
changed the title
|
Switching to draft as there's apparently a regression when executing integration tests. |
* Fix bad prefix in filters internal ids
tmortagne
reviewed
Jun 5, 2024
...latform-legacy-notifications-filters/xwiki-platform-legacy-notifications-filters-api/pom.xml
Outdated
Show resolved
Hide resolved
tmortagne
reviewed
Jun 5, 2024
...ava/org/xwiki/notifications/filters/internal/DefaultNotificationFilterPreferenceManager.java
Outdated
Show resolved
Hide resolved
tmortagne
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22211
Changes
Description
NotificationFilterPreference#getProviderHint
NotificationFilterPreference
preference was stored or not: replaced it with checking the ID of
the filter
Clarifications
N/A
Executed Tests
mvn clean install -Pquality,integration-tests,dockeron bothxwiki-platform-notificationsandxwiki-platform-legacy-notifications.Expected merging strategy