Sourcery refactored main branch #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/main
branch
from
bd99ce9
to
2ec862d
Compare
Comment on lines
-22
to
+30
| if not any([hostORip,database,usrID,pwd]): | ||
| if not any([hostORip, database, usrID, pwd]): | ||
| raise Exception("Partially inputs, please check your inputs...") | ||
| else: | ||
| self.filePath = filePath | ||
| self.hostORip = hostORip | ||
| self.database=database | ||
| self.usrID = usrID | ||
| self.pwd = pwd | ||
| self.save2tableName = save2tableName | ||
|
|
||
| self.filePath = filePath | ||
| self.hostORip = hostORip | ||
| self.database=database | ||
| self.usrID = usrID | ||
| self.pwd = pwd | ||
| self.save2tableName = save2tableName | ||
|
|
There was a problem hiding this comment.
Function exceltoDBtable.__init__ refactored with the following changes:
- Swap if/else branches [×2] (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-49
to
+70
|
|
||
|
|
||
| try: | ||
| self.engine = create_engine("mssql+pyodbc://%s:%s@%s/%s?driver=%s?"%(self.usrID,self.pwd,self.hostORip,self.database,driveString)) | ||
| self.engine = create_engine( | ||
| f"mssql+pyodbc://{self.usrID}:{self.pwd}@{self.hostORip}/{self.database}?driver={driveString}?" | ||
| ) | ||
|
|
||
| print("Seccessfully connected to SQL Server...") | ||
|
|
||
| if self.save2tableName: | ||
| tableName = self.save2tableName | ||
| elif "/" in self.filePath: | ||
| tableName = self.filePath.split("/")[-1].split(".")[0] | ||
| else: | ||
| if "/" in self.filePath: | ||
| tableName = self.filePath.split("/")[-1].split(".")[0] | ||
| else: | ||
| tableName = self.filePath.split(".")[0] | ||
|
|
||
| tableName = self.filePath.split(".")[0] | ||
|
|
||
| self.file_data.to_sql(tableName,con=self.engine) | ||
| print("Successfully saved %s into SQL Server..."%tableName) | ||
| return None | ||
| print(f"Successfully saved {tableName} into SQL Server...") | ||
| return None | ||
| except: | ||
| self.engine = False | ||
| continue | ||
|
|
There was a problem hiding this comment.
Function exceltoDBtable.connect2DB refactored with the following changes:
- Replace interpolated string formatting with f-string [×2] (
replace-interpolation-with-fstring) - Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
Comment on lines
-22
to
+30
| if not any([hostORip,database,usrID,pwd]): | ||
| if not any([hostORip, database, usrID, pwd]): | ||
| raise Exception("Partially inputs, please check your inputs...") | ||
| else: | ||
| self.filePath = filePath | ||
| self.hostORip = hostORip | ||
| self.database=database | ||
| self.usrID = usrID | ||
| self.pwd = pwd | ||
| self.save2tableName = save2tableName | ||
|
|
||
| self.filePath = filePath | ||
| self.hostORip = hostORip | ||
| self.database=database | ||
| self.usrID = usrID | ||
| self.pwd = pwd | ||
| self.save2tableName = save2tableName | ||
|
|
There was a problem hiding this comment.
Function exceltoDBtable.__init__ refactored with the following changes:
- Swap if/else branches [×2] (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-49
to
+70
|
|
||
|
|
||
| try: | ||
| self.engine = create_engine("mssql+pyodbc://%s:%s@%s/%s?driver=%s?"%(self.usrID,self.pwd,self.hostORip,self.database,driveString)) | ||
| self.engine = create_engine( | ||
| f"mssql+pyodbc://{self.usrID}:{self.pwd}@{self.hostORip}/{self.database}?driver={driveString}?" | ||
| ) | ||
|
|
||
| print("Seccessfully connected to SQL Server...") | ||
|
|
||
| if self.save2tableName: | ||
| tableName = self.save2tableName | ||
| elif "/" in self.filePath: | ||
| tableName = self.filePath.split("/")[-1].split(".")[0] | ||
| else: | ||
| if "/" in self.filePath: | ||
| tableName = self.filePath.split("/")[-1].split(".")[0] | ||
| else: | ||
| tableName = self.filePath.split(".")[0] | ||
|
|
||
| tableName = self.filePath.split(".")[0] | ||
|
|
||
| self.file_data.to_sql(tableName,con=self.engine) | ||
| print("Successfully saved %s into SQL Server..."%tableName) | ||
| return None | ||
| print(f"Successfully saved {tableName} into SQL Server...") | ||
| return None | ||
| except: | ||
| self.engine = False | ||
| continue | ||
|
|
There was a problem hiding this comment.
Function exceltoDBtable.connect2DB refactored with the following changes:
- Replace interpolated string formatting with f-string [×2] (
replace-interpolation-with-fstring) - Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.99%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!