Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#665 Adds 2.2.1 and 2.3.0 support #669

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmax01
Copy link

@jmax01 jmax01 commented Aug 1, 2019

[Do not merge as not fully functional for 2.3.0 due to API changes in 2.30]

fixes #667

fixes #668

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@selinaleung
Copy link

thanks for the contributions! Do you happen to have an estimate on when this update will be released? @jmax01

@jmax01
Copy link
Author

jmax01 commented Sep 27, 2019

thanks for the contributions! Do you happen to have an estimate on when this update will be released? @jmax01

I moved organizations and for the foreseeable future I won't be working with kafka-manager.

@reinoudk
Copy link

What's the current status / way forward for this PR? Would be a shame if it ends up in limbo.

@patelh
Copy link
Collaborator

patelh commented Oct 17, 2019

Will look at this in the coming weeks.

@henhiskan
Copy link

henhiskan commented Nov 11, 2019

I have a kafka 2.3 cluster with KAFKA_LOG_MESSAGE_FORMAT_VERSION: 2.3 , I just installed this PR to test it in two clusters and on both I got these message:

019-11-11 21:43:44,149 - [WARN] k.m.a.c.KafkaManagedOffsetCache - Failed to process a message from offset topic on cluster kafka-kafka.data!
org.apache.kafka.common.KafkaException: Unknown group metadata version 3
	at kafka.manager.utils.one10.GroupMetadataManager$.schemaForGroupValue(GroupMetadataManager.scala:554)
	at kafka.manager.utils.one10.GroupMetadataManager$.readGroupMessageValue(GroupMetadataManager.scala:726)
	at kafka.manager.actor.cluster.KafkaManagedOffsetCache.$anonfun$run$3(KafkaStateActor.scala:377)
	at kafka.manager.actor.cluster.KafkaManagedOffsetCache.$anonfun$run$3$adapted(KafkaStateActor.scala:325)
	at scala.util.Success.foreach(Try.scala:253)
	at kafka.manager.actor.cluster.KafkaManagedOffsetCache.run(KafkaStateActor.scala:325)
	at java.lang.Thread.run(Thread.java:748)

@austinnichols101
Copy link

Same error described in #588

@meticulo3366
Copy link

Hi, when are we merging this feature branch into master?

@jigs1993
Copy link

jigs1993 commented Jun 3, 2020

can we merge this into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants