This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I finally had some time to work on this. I'm not sure what your thoughts are on this but since upstream mcrouter has started adding
FOLLY_COMMIT
files, this is all much easier.This PR is an attempt to accomplish two things:
Currently, there is a problem upstream. The 0.15.0 (newest release as of now) does not contain the
FOLLY_COMMIT
file. The correct SHA with that file is actually facebook/mcrouter@bbc2a52So I would suggest that we wait for their next release and do some testing then when considering merging this in or not.