Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

14.04 support #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kevinquinnyo
Copy link

So I finally had some time to work on this. I'm not sure what your thoughts are on this but since upstream mcrouter has started adding FOLLY_COMMIT files, this is all much easier.

This PR is an attempt to accomplish two things:

  1. Add support for 14.04 without breaking 12.04 support or making too many changes
  2. Try to automate the builds further by pulling down the Mcrouter version and commit hash automatically. This is so that the builds could be setup via cron if desired, without having to manually add the newest SHA hash.

Currently, there is a problem upstream. The 0.15.0 (newest release as of now) does not contain the FOLLY_COMMIT file. The correct SHA with that file is actually facebook/mcrouter@bbc2a52

So I would suggest that we wait for their next release and do some testing then when considering merging this in or not.

- Additional changes:
  - snags the latest MCROUTER_SHA variable automagically from
    upstream mcrouter
  - one missing dependency "software-properties-common" needed for
    14.04
  - .debs are now pulled down from docker to ./14.04/ or ./12.04/
@msftclas
Copy link

Hi @kevinquinnyo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

- software-properties-common NOT python-software-properties
- replace "12.04" in Makefile test with UBUNTU_RELEASE var
@bmorton
Copy link
Contributor

bmorton commented Dec 18, 2015

Thanks for doing this! I probably won't have too much time until I get through the holidays a bit, but I'll get back to you on this as soon as I have a chance to dig in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants