feature: return multierr on Close call #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidh
reviewed
Sep 10, 2023
| @@ -28,7 +28,6 @@ func TestClusterDefaults(t *testing.T) { | |||
| f := newFixture(t, 1) | |||
| c, err := NewCluster(f.ClusterNodes(), f.PrimaryChecker) | |||
| require.NoError(t, err) | |||
| defer func() { require.NoError(t, c.Close()) }() | |||
There was a problem hiding this comment.
Why Close is removed here and in other tests?
There was a problem hiding this comment.
It has been removed due to pointlessness. The only reason it has been called is due to expectation in test suite generator. AFAIK hasql does not oblige user to call Close at any point.
As expectation has been removed so were all Close calls in tests. Close method has its own test function, so I believe all test cases relevant to cluster teardown must be placed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped minimal Go version to 1.20 to leverage new language feature:
errors.Join. It allows to return all connections errors occurred while closing cluster.