Merge pull request #1350 remove quotas from background goroutine label

ydb-platform · Jul 18, 2024 · a70a04e · a70a04e
2 parents 2303ce2 + 3b236cf
commit a70a04e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Removed double quotas from goroutine labels background workers for prevent problem with pprof
+
 ## v3.75.2
 * Fixed build for go1.20
 

diff --git a/internal/background/worker.go b/internal/background/worker.go
@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"runtime/pprof"
+	"strings"
 	"sync"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/empty"
@@ -144,7 +145,9 @@ func (b *Worker) starterLoop(ctx context.Context) {
 		go func(task backgroundTask) {
 			defer b.workers.Done()
 
-			pprof.Do(ctx, pprof.Labels("background", task.name), task.callback)
+			safeLabel := strings.ReplaceAll(task.name, `"`, `'`)
+
+			pprof.Do(ctx, pprof.Labels("background", safeLabel), task.callback)
 		}(bgTask)
 	}
 }