Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codegeneration for stack.FunctionID #1114

Merged
merged 18 commits into from
Mar 24, 2024

Conversation

anatoly32322
Copy link
Contributor

@anatoly32322 anatoly32322 commented Mar 8, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@anatoly32322
Copy link
Contributor Author

Пока не до конца рабочий вариант:

  • Не добавлено в CI
  • Пару случаев FunctionID не видит
  • Планирую упростить код, пока выглядит слишком запутанно из-за большого количества рекурсий

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all internal tools must placed in internal/cmd package
What do you think about path internal/cmd/gstack ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll move it to gstack


import (
"fmt"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/stack"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix imports ordering for pass gci linter checks

anatoly32322 and others added 2 commits March 14, 2024 16:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 32.58145% with 269 lines in your changes are missing coverage. Please review.

Project coverage is 67.64%. Comparing base (895d516) to head (ffd3ee0).
Report is 3 commits behind head on master.

Files Patch % Lines
internal/cmd/gstack/main.go 0.00% 170 Missing ⚠️
internal/cmd/gstack/utils/utils.go 0.00% 90 Missing ⚠️
internal/xsql/tx_fake.go 0.00% 5 Missing ⚠️
driver.go 75.00% 1 Missing ⚠️
internal/conn/pool.go 83.33% 1 Missing ⚠️
internal/scheme/client.go 83.33% 1 Missing ⚠️
internal/table/transaction.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
- Coverage   67.90%   67.64%   -0.26%     
==========================================
  Files         298      300       +2     
  Lines       30113    30411     +298     
==========================================
+ Hits        20448    20572     +124     
- Misses       8738     8920     +182     
+ Partials      927      919       -8     
Flag Coverage Δ
53.30% <89.92%> (+0.69%) ⬆️
go-1.21.x 69.47% <93.52%> (-0.04%) ⬇️
go-1.22.x 67.63% <32.58%> (-0.23%) ⬇️
integration 53.30% <89.92%> (+0.69%) ⬆️
macOS 39.87% <11.77%> (-0.36%) ⬇️
ubuntu 39.88% <11.77%> (-0.38%) ⬇️
unit 39.92% <11.77%> (-0.37%) ⬇️
windows 39.90% <11.77%> (-0.37%) ⬇️
ydb-23.3 47.75% <66.18%> (-0.03%) ⬇️
ydb-24.1 53.15% <89.92%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Rename codegeneration.go -> main.go
CHANGELOG.md Outdated Show resolved Hide resolved
anatoly32322 and others added 2 commits March 23, 2024 16:48
@asmyasnikov asmyasnikov merged commit 8e6ec46 into ydb-platform:master Mar 24, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants