-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codegeneration for stack.FunctionID #1114
Add codegeneration for stack.FunctionID #1114
Conversation
Пока не до конца рабочий вариант:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all internal tools must placed in internal/cmd package
What do you think about path internal/cmd/gstack ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll move it to gstack
|
||
import ( | ||
"fmt" | ||
"github.com/ydb-platform/ydb-go-sdk/v3/internal/stack" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix imports ordering for pass gci linter checks
Put in stack.FunctionID's argument only filename Sort imports
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
- Coverage 67.90% 67.64% -0.26%
==========================================
Files 298 300 +2
Lines 30113 30411 +298
==========================================
+ Hits 20448 20572 +124
- Misses 8738 8920 +182
+ Partials 927 919 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Rename codegeneration.go -> main.go
dc49220
to
f3318fb
Compare
4bb8a9c
to
88ccf0b
Compare
Rename codegeneration.go -> main.go
dc2e6ed
to
de98eb7
Compare
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information