Refactoring

[asmyasnikov]

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

[github-actions]

github.com/ydb-platform/ydb-go-sdk/v3/balancers

incompatible changes

Endpoint.LocalDC: removed
PreferWithFallback: changed from func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config.Config, func(endpoint Endpoint) bool) *github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config.Config to func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config.Config, func(endpoint github.com/ydb-platform/ydb-go-sdk/v3/internal/conn.Info) bool) *github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config.Config

github.com/ydb-platform/ydb-go-sdk/v3/discovery

incompatible changes

Client.Discover: changed from func(context.Context) ([]github.com/ydb-platform/ydb-go-sdk/v3/internal/endpoint.Endpoint, error) to func(context.Context) ([]github.com/ydb-platform/ydb-go-sdk/v3/internal/endpoint.Info, error)

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

ConnState.Code: removed
ConnState.IsValid: removed
Driver.OnConnAllow: removed
DriverConnAllowDoneInfo: removed
DriverConnAllowStartInfo: removed
DriverOnConnAllow: removed
EndpointInfo.LocalDC: removed

compatible changes

Driver.OnBalancerGetConn: added
Driver.OnBalancerMarkConnAsBad: added
Driver.OnConnUnban: added
Driver.OnPoolAttach: added
Driver.OnPoolDetach: added
DriverBalancerGetConnDoneInfo: added
DriverBalancerGetConnStartInfo: added
DriverBalancerMarkConnAsBadDoneInfo: added
DriverBalancerMarkConnAsBadStartInfo: added
DriverConnPoolAttachDoneInfo: added
DriverConnPoolAttachStartInfo: added
DriverConnPoolDetachDoneInfo: added
DriverConnPoolDetachStartInfo: added
DriverConnUnbanDoneInfo: added
DriverConnUnbanStartInfo: added
DriverOnBalancerGetConn: added
DriverOnBalancerMarkConnAsBad: added
DriverOnConnUnban: added
DriverOnPoolAttach: added
DriverOnPoolDetach: added

summary

Base version: v3.64.1-0.20240410130004-d38f4eca0386 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.64.0.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 35.32110% with 423 lines in your changes are missing coverage. Please review.

Project coverage is 39.97%. Comparing base (a0abd92) to head (cae12e7).
Report is 6 commits behind head on master.

Files	Patch %	Lines
internal/conn/conn.go	0.00%	121 Missing ⚠️
internal/conn/grpc_client_stream.go	0.00%	80 Missing ⚠️
internal/balancer/balancer.go	23.95%	70 Missing and 3 partials ⚠️
internal/conn/cc_guard.go	0.00%	47 Missing ⚠️
internal/balancer/connections.go	75.40%	29 Missing and 1 partial ⚠️
internal/conn/pool.go	0.00%	26 Missing ⚠️
internal/conn/last_usage_guard.go	50.00%	13 Missing ⚠️
internal/mock/endpoint.go	35.00%	13 Missing ⚠️
internal/query/result_set.go	85.71%	3 Missing and 1 partial ⚠️
internal/conn/in_use_quard.go	85.71%	2 Missing and 1 partial ⚠️
... and 7 more

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1174       +/-   ##
===========================================
- Coverage   68.23%   39.97%   -28.26%     
===========================================
  Files         307      310        +3     
  Lines       32017    32199      +182     
===========================================
- Hits        21847    12873     -8974     
- Misses       9218    18905     +9687     
+ Partials      952      421      -531     

Flag	Coverage Δ
	?
go-1.21.x	41.89% <34.08%> (-28.46%)	⬇️
go-1.22.x	39.97% <35.32%> (-27.77%)	⬇️
integration	?
macOS	39.93% <35.32%> (+0.76%)	⬆️
ubuntu	39.93% <35.32%> (+0.75%)	⬆️
unit	39.97% <35.32%> (+0.73%)	⬆️
windows	39.97% <35.32%> (+0.79%)	⬆️
ydb-23.3	?
ydb-24.1	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

[github-actions]

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

[github-actions]

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

[github-actions]

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard