Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled structcheck linter #1219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

viktormas
Copy link

@viktormas viktormas commented May 5, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #966

What is the new behavior?

Other information

@@ -19,8 +19,6 @@ import (
)

type testItem struct {
v uint32
Copy link
Author

@viktormas viktormas May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was removed because the structcheck linter wrote internal/pool/pool_test.go:22:2: "v" is unused (structcheck) v uint32

@@ -23,7 +23,6 @@ type PublicMessage struct {
// partitioning at level message available by protocol, but doesn't available by current server implementation
// the field hidden from public access for prevent runtime errors.
// it will be published after implementation on server side.
futurePartitioning PublicFuturePartitioning
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was removed because the structcheck linter wrote internal/topic/topicwriterinternal/message.go:26:2: "futurePartitioning" is unused (structcheck) futurePartitioning PublicFuturePartitioning

@@ -22,5 +21,4 @@ type WritersCommonConfig struct {
cred credentials.Credentials
credUpdateInterval time.Duration
clock clockwork.Clock
forceCodec rawtopiccommon.Codec
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was removed because the structcheck linter wrote internal/topic/topicwriterinternal/writer_config.go:25:2: "forceCodec" is unused (structcheck) forceCodec rawtopiccommon.Codec

@@ -6,7 +6,6 @@ import (
"github.com/jonboulle/clockwork"

"github.com/ydb-platform/ydb-go-sdk/v3/credentials"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/grpcwrapper/rawtopic/rawtopiccommon"
Copy link
Author

@viktormas viktormas May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t remove this, but when I added it back, the development environment began to issue “unused import”.

@asmyasnikov asmyasnikov changed the title structcheck1 Enabled structcheck linter May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant