Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use buffered channel to manage items in query pool #1320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the bug Something isn't working label Jul 3, 2024
@asmyasnikov asmyasnikov self-assigned this Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

summary

Base version: v3.74.6-0.20240704085220-890206eacaa7 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.74.5.

Copy link

github-actions bot commented Jul 3, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Jul 3, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Jul 3, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Jul 3, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Jul 3, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

Copy link

github-actions bot commented Jul 3, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@adwski adwski force-pushed the internal-pool-with-buffered-channel branch from 61cafd1 to a78bced Compare July 5, 2024 09:47
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 93.81443% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.73%. Comparing base (890206e) to head (a78bced).
Report is 96 commits behind head on master.

Files Patch % Lines
internal/pool/pool.go 93.81% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1320   +/-   ##
=======================================
  Coverage   41.73%   41.73%           
=======================================
  Files         321      321           
  Lines       34050    34073   +23     
=======================================
+ Hits        14211    14222   +11     
- Misses      19371    19379    +8     
- Partials      468      472    +4     
Flag Coverage Δ
go-1.20.x 44.02% <93.81%> (-0.02%) ⬇️
go-1.21.x 44.03% <93.81%> (-0.03%) ⬇️
go-1.22.x 41.70% <93.81%> (+<0.01%) ⬆️
macOS 41.25% <92.77%> (+0.04%) ⬆️
ubuntu 41.22% <92.77%> (-0.01%) ⬇️
unit 41.73% <93.81%> (+<0.01%) ⬆️
windows 41.71% <93.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants