Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring of connections state #1352

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Jul 18, 2024
Copy link

github-actions bot commented Jul 18, 2024

summary

Base version: v3.76.2-0.20240801103241-91cf42de33fa (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.76.2-rc0.

Copy link

github-actions bot commented Jul 25, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Jul 25, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Jul 25, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

Copy link

github-actions bot commented Jul 25, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Jul 25, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Jul 25, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 44.08602% with 104 lines in your changes missing coverage. Please review.

Project coverage is 41.74%. Comparing base (91cf42d) to head (cefa7d0).

Files Patch % Lines
internal/balancer/balancer.go 47.14% 31 Missing and 6 partials ⚠️
internal/conn/pool.go 0.00% 31 Missing ⚠️
internal/conn/conn.go 24.13% 20 Missing and 2 partials ⚠️
internal/balancer/cluster/cluster.go 78.84% 10 Missing and 1 partial ⚠️
internal/conn/grpc_client_stream.go 0.00% 2 Missing ⚠️
driver.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   41.85%   41.74%   -0.11%     
==========================================
  Files         351      350       -1     
  Lines       35226    35054     -172     
==========================================
- Hits        14745    14635     -110     
+ Misses      20000    19928      -72     
- Partials      481      491      +10     
Flag Coverage Δ
go-1.20.x 43.62% <44.08%> (-0.07%) ⬇️
go-1.21.x 43.61% <44.08%> (-0.08%) ⬇️
go-1.22.x 41.70% <44.08%> (-0.13%) ⬇️
macOS 41.26% <44.24%> (-0.14%) ⬇️
ubuntu 41.27% <44.24%> (-0.12%) ⬇️
unit 41.74% <44.08%> (-0.11%) ⬇️
windows 41.73% <44.08%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants