Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added simple wrapper for grpc errors for getting nodeID and address #1391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github-actions bot commented Aug 2, 2024

summary

Base version: v3.76.2-0.20240801181836-c78681e9d80e (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.76.2-rc0.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.

Project coverage is 41.88%. Comparing base (c78681e) to head (aeee9de).

Files Patch % Lines
internal/xerrors/operation.go 0.00% 4 Missing ⚠️
internal/xerrors/transport.go 33.33% 4 Missing ⚠️
internal/conn/grpc_client_stream.go 0.00% 3 Missing ⚠️
internal/conn/conn.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1391      +/-   ##
==========================================
- Coverage   41.89%   41.88%   -0.01%     
==========================================
  Files         351      351              
  Lines       35226    35248      +22     
==========================================
+ Hits        14758    14765       +7     
- Misses      19987    20001      +14     
- Partials      481      482       +1     
Flag Coverage Δ
go-1.20.x 43.68% <55.17%> (-0.06%) ⬇️
go-1.21.x 43.69% <55.17%> (-0.04%) ⬇️
go-1.22.x 41.84% <55.17%> (+0.01%) ⬆️
macOS 41.38% <53.57%> (-0.02%) ⬇️
ubuntu 41.43% <53.57%> (+<0.01%) ⬆️
unit 41.88% <55.17%> (-0.01%) ⬇️
windows 41.84% <55.17%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 2, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Aug 2, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Aug 2, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Aug 2, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Aug 2, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Aug 2, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service with session pool:

Grafana Dashboard

SLO-native-query-with-pool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants