Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ChangefeedFormatDynamoDBStreamsJSON constant #800

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Conversation

rekby
Copy link
Member

@rekby rekby commented Aug 1, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

Add constant ChangefeedFormatDynamoDBStreamsJSON

@rekby rekby marked this pull request as ready for review August 1, 2023 12:55
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

github.com/ydb-platform/ydb-go-sdk/v3/table/options

compatible changes

ChangefeedFormatDynamoDBStreamsJSON: added

summary

Base version: v3.49.0-rc0.0.20230801005458-b2dd07037119 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.49.0-rc0.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -25.42% ⚠️

Comparison is base (b2dd070) 66.37% compared to head (2e48598) 40.95%.

❗ Current head 2e48598 differs from pull request most recent head c3205c8. Consider uploading reports for the commit c3205c8 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #800       +/-   ##
===========================================
- Coverage   66.37%   40.95%   -25.42%     
===========================================
  Files         233      171       -62     
  Lines       23030    18909     -4121     
===========================================
- Hits        15287     7745     -7542     
- Misses       6944    10823     +3879     
+ Partials      799      341      -458     
Flag Coverage Δ
?
go-1.17.x 40.95% <ø> (-25.06%) ⬇️
go-1.19.x ?
go-1.20.x ?
integration ?
macOS ?
ubuntu 40.95% <ø> (-0.32%) ⬇️
unit 40.95% <ø> (-0.37%) ⬇️
windows ?
ydb-22.5 ?
ydb-23.1 ?
ydb-23.2 ?
ydb-23.2-slim ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
table/options/models.go 38.09% <ø> (-15.88%) ⬇️

... and 175 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit d3f9e4f into master Aug 1, 2023
@asmyasnikov asmyasnikov deleted the add-cdc-format branch August 1, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants