Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused fields from ReaderSettings #337

Merged

Conversation

Myllyenko
Copy link

Removing unused fields to avoid misconfiguration of a reader.

  • Looks like maxLag and readFrom were added to ReaderSettings by mistake because they belong to TopicReadSettings.
  • decompress is unused at least for now.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.38%. Comparing base (959538e) to head (c0d89f5).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #337      +/-   ##
============================================
+ Coverage     47.34%   47.38%   +0.04%     
  Complexity     1750     1750              
============================================
  Files           309      309              
  Lines         12463    12448      -15     
  Branches       1232     1232              
============================================
- Hits           5901     5899       -2     
+ Misses         6102     6089      -13     
  Partials        460      460              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1
Copy link
Collaborator

pnv1 commented Oct 23, 2024

Thank you for noticing! It's really better to just remove these options until they are used in any way

@pnv1 pnv1 merged commit ebe9f19 into ydb-platform:master Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants