-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing synchronized blocks with ReentrantLocks in core part of SDK #341
Replacing synchronized blocks with ReentrantLocks in core part of SDK #341
Conversation
} | ||
} | ||
|
||
@Override | ||
public void onClose(io.grpc.Status status, @Nullable Metadata trailers) { | ||
if (logger.isTraceEnabled()) { | ||
logger.trace("ReadWriteStreamCall[{}] closed with status {}", status); | ||
logger.trace("ReadWriteStreamCall[{}] closed with status {}", traceId, status); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First log argument was absent
core/src/main/java/tech/ydb/core/impl/call/ReadWriteStreamCall.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
============================================
+ Coverage 47.19% 47.21% +0.01%
Complexity 1750 1750
============================================
Files 311 311
Lines 12499 12499
Branches 1238 1238
============================================
+ Hits 5899 5901 +2
+ Misses 6140 6138 -2
Partials 460 460 ☔ View full report in Codecov by Sentry. |
I am not sure that we have to remove |
Reverted changes in |
Continuation of #338