Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New field additionalPodLabels #237

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

New field additionalPodLabels #237

wants to merge 14 commits into from

Conversation

kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Jul 14, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No way to configure additional pod labels - only for Pod api resource.
Field additionalLabels append new labels to all objects

What is the new behavior?

  • field additionalPodLabels in CRD Storage and Database spec
  • new method buildPodTemplateLabels to append additionalPodLabels for statefulset builders
  • refactor package labels and move code to methods buildLabels, buildSelectorLabels and buildeNodeSetLabels for each resource
  • save labels ydb.tech/database-nodeset, ydb.tech/storage-nodeset and ydb.tech/remote-cluster by func makeCommonLabels between resources recast

Other information

fix e2e test objects to maintain affinity rules

@kobzonega kobzonega changed the title Additional pod labels additional pod labels Jul 15, 2024
@kobzonega kobzonega force-pushed the additionalPodLabels branch 2 times, most recently from 2e4cc09 to 80e1d53 Compare July 16, 2024 05:32
@kobzonega kobzonega changed the title additional pod labels New field additionalPodLabels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant